small fixes

Author: HardMax71

backend/app/schemas_pydantic/execution.py

@@ -73,13 +73,12 @@ class ExecutionRequest(BaseModel):
 
     @model_validator(mode="after")
     def validate_runtime_supported(self) -> "ExecutionRequest":  # noqa: D401
-        settings = get_settings()
-        runtimes = settings.SUPPORTED_RUNTIMES or {}
-        if self.lang not in runtimes:
+        runtimes = get_settings().SUPPORTED_RUNTIMES
+        if not (lang_info := runtimes.get(self.lang)):
             raise ValueError(f"Language '{self.lang}' not supported. Supported: {list(runtimes.keys())}")
-        lang_info = runtimes[self.lang]
         if self.lang_version not in lang_info.versions:
-            raise ValueError(f"Version '{self.lang_version}' not supported for {self.lang}. Supported: {lang_info.versions}")
+            raise ValueError(f"Version '{self.lang_version}' not supported for {self.lang}. "
+                             f"Supported: {lang_info.versions}")
         return self
 
 

frontend/src/lib/__tests__/user-settings.test.ts

@@ -9,11 +9,9 @@ vi.mock('../api', () => ({
 }));
 
 const mockSetUserSettings = vi.fn();
-const mockUpdateSettings = vi.fn();
 
 vi.mock('../../stores/userSettings', () => ({
   setUserSettings: (settings: unknown) => mockSetUserSettings(settings),
-  updateSettings: (partial: unknown) => mockUpdateSettings(partial),
 }));
 
 const mockSetThemeLocal = vi.fn();
@@ -38,7 +36,6 @@ describe('user-settings', () => {
     mockGetUserSettings.mockReset();
     mockUpdateUserSettings.mockReset();
     mockSetUserSettings.mockReset();
-    mockUpdateSettings.mockReset();
     mockSetThemeLocal.mockReset();
 
     mockIsAuthenticated = true;
@@ -170,16 +167,18 @@ describe('user-settings', () => {
     });
 
     it('updates store on success', async () => {
-      mockUpdateUserSettings.mockResolvedValue({ data: {}, error: null });
+      const responseData = { user_id: '123', theme: 'system' };
+      mockUpdateUserSettings.mockResolvedValue({ data: responseData, error: null });
 
       const { saveUserSettings } = await import('../user-settings');
       await saveUserSettings({ theme: 'system' });
 
-      expect(mockUpdateSettings).toHaveBeenCalledWith({ theme: 'system' });
+      expect(mockSetUserSettings).toHaveBeenCalledWith(responseData);
     });
 
     it('applies theme locally when theme is saved', async () => {
-      mockUpdateUserSettings.mockResolvedValue({ data: {}, error: null });
+      const responseData = { user_id: '123', theme: 'dark' };
+      mockUpdateUserSettings.mockResolvedValue({ data: responseData, error: null });
 
       const { saveUserSettings } = await import('../user-settings');
       await saveUserSettings({ theme: 'dark' });
@@ -188,7 +187,8 @@ describe('user-settings', () => {
     });
 
     it('does not apply theme when only editor settings saved', async () => {
-      mockUpdateUserSettings.mockResolvedValue({ data: {}, error: null });
+      const responseData = { user_id: '123', editor: { font_size: 16 } };
+      mockUpdateUserSettings.mockResolvedValue({ data: responseData, error: null });
 
       const { saveUserSettings } = await import('../user-settings');
       await saveUserSettings({ editor: { font_size: 16 } });

frontend/src/lib/user-settings.ts

@@ -1,13 +1,14 @@
 import { get } from 'svelte/store';
 import { isAuthenticated } from '../stores/auth';
 import { setThemeLocal } from '../stores/theme';
-import { setUserSettings, updateSettings } from '../stores/userSettings';
+import { setUserSettings } from '../stores/userSettings';
 import {
     getUserSettingsApiV1UserSettingsGet,
     updateUserSettingsApiV1UserSettingsPut,
     type UserSettings,
     type UserSettingsUpdate,
 } from './api';
+import { unwrap } from './api-interceptors';
 
 export async function loadUserSettings(): Promise<UserSettings | undefined> {
     try {
@@ -34,17 +35,11 @@ export async function saveUserSettings(partial: UserSettingsUpdate): Promise<boo
     if (!get(isAuthenticated)) return false;
 
     try {
-        const { error } = await updateUserSettingsApiV1UserSettingsPut({ body: partial });
-
-        if (error) {
-            console.error('Failed to save user settings:', error);
-            return false;
-        }
-
-        updateSettings(partial as Partial<UserSettings>);
+        const data = unwrap(await updateUserSettingsApiV1UserSettingsPut({ body: partial }));
+        setUserSettings(data);
 
-        if (partial.theme) {
-            setThemeLocal(partial.theme);
+        if (data.theme) {
+            setThemeLocal(data.theme);
         }
 
         return true;

frontend/src/stores/userSettings.ts

@@ -21,10 +21,6 @@ export function setUserSettings(settings: UserSettings | null): void {
     userSettings.set(settings);
 }
 
-export function updateSettings(partial: Partial<UserSettings>): void {
-    userSettings.update(current => current ? { ...current, ...partial } : null);
-}
-
 export function clearUserSettings(): void {
     userSettings.set(null);
 }