Skip to content

Commit 31475fe

Browse files
committed
automatic build/load of base container
1 parent 06722cb commit 31475fe

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/docker.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ jobs:
3434
- name: Set up Docker Buildx
3535
uses: docker/setup-buildx-action@v3
3636

37+
# Always login - needed even for PRs to push base image for dependent builds
3738
- name: Log in to GitHub Container Registry
38-
if: github.event_name != 'pull_request'
3939
uses: docker/login-action@v3
4040
with:
4141
registry: ${{ env.REGISTRY }}
@@ -63,13 +63,12 @@ jobs:
6363
with:
6464
context: ./backend
6565
file: ./backend/Dockerfile.base
66-
push: ${{ github.event_name != 'pull_request' }}
66+
# Always push base - backend/frontend depend on it via build-contexts
67+
push: true
6768
tags: ${{ steps.meta-base.outputs.tags }}
6869
labels: ${{ steps.meta-base.outputs.labels }}
6970
cache-from: type=gha
7071
cache-to: type=gha,mode=max
71-
# Also build locally for dependent images
72-
load: true
7372

7473
# =========================================================================
7574
# BACKEND IMAGE

0 commit comments

Comments
 (0)