Skip to content

Commit 38576de

Browse files
committed
error display fix + moved from project name to db name for database
1 parent f6c1dd0 commit 38576de

File tree

10 files changed

+28
-25
lines changed

10 files changed

+28
-25
lines changed

backend/app/core/providers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class DatabaseProvider(Provider):
9090
async def get_database_connection(self, settings: Settings) -> AsyncIterator[AsyncDatabaseConnection]:
9191
db_config = DatabaseConfig(
9292
mongodb_url=settings.MONGODB_URL,
93-
db_name=settings.PROJECT_NAME,
93+
db_name=settings.DATABASE_NAME,
9494
server_selection_timeout_ms=5000,
9595
connect_timeout_ms=5000,
9696
max_pool_size=50,

backend/app/services/coordinator/coordinator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ async def run_coordinator() -> None:
554554
tz_aware=True,
555555
serverSelectionTimeoutMS=5000
556556
)
557-
db_name = settings.PROJECT_NAME
557+
db_name = settings.DATABASE_NAME
558558
database = db_client[db_name]
559559

560560
await SchemaManager(database).apply_all()

backend/app/services/k8s_worker/worker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ async def run_kubernetes_worker() -> None:
561561
tz_aware=True,
562562
serverSelectionTimeoutMS=5000
563563
)
564-
db_name = settings.PROJECT_NAME
564+
db_name = settings.DATABASE_NAME
565565
database = db_client[db_name]
566566
await db_client.admin.command("ping")
567567
logger.info(f"Connected to database: {db_name}")

backend/app/settings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
class Settings(BaseSettings):
1111
PROJECT_NAME: str = "integr8scode"
12+
DATABASE_NAME: str = "integr8scode_db"
1213
API_V1_STR: str = "/api/v1"
1314
SECRET_KEY: str = Field(
1415
..., # Actual key be loaded from .env file

backend/scripts/seed_users.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ async def upsert_user(
6464

6565
async def seed_users() -> None:
6666
mongodb_url = os.getenv("MONGODB_URL", "mongodb://mongo:27017/integr8scode")
67-
db_name = os.getenv("PROJECT_NAME", "integr8scode")
67+
db_name = os.getenv("DATABASE_NAME", "integr8scode_db")
6868

6969
print(f"Connecting to MongoDB (database: {db_name})...")
7070

backend/workers/dlq_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ async def main() -> None:
101101
tz_aware=True,
102102
serverSelectionTimeoutMS=5000,
103103
)
104-
db_name = settings.PROJECT_NAME + "_test" if settings.TESTING else settings.PROJECT_NAME
104+
db_name = settings.DATABASE_NAME
105105
database: AsyncIOMotorDatabase = db_client[db_name]
106106
await db_client.admin.command("ping")
107107
logger.info(f"Connected to database: {db_name}")

backend/workers/run_event_replay.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ async def run_replay_service() -> None:
4040
tz_aware=True,
4141
serverSelectionTimeoutMS=5000
4242
)
43-
db_name = settings.PROJECT_NAME + "_test" if settings.TESTING else settings.PROJECT_NAME
43+
db_name = settings.DATABASE_NAME
4444
database = db_client[db_name]
4545

4646
# Verify connection

backend/workers/run_saga_orchestrator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ async def run_saga_orchestrator() -> None:
3131
tz_aware=True,
3232
serverSelectionTimeoutMS=5000
3333
)
34-
db_name = settings.PROJECT_NAME + "_test" if settings.TESTING else settings.PROJECT_NAME
34+
db_name = settings.DATABASE_NAME
3535
database = db_client[db_name]
3636

3737
# Verify connection

frontend/src/components/ErrorDisplay.svelte

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,23 @@
11
<script lang="ts">
2-
let { error, title = 'Application Error', showDetails = true }: {
2+
let { error, title = 'Application Error' }: {
33
error: Error | string;
44
title?: string;
5-
showDetails?: boolean;
65
} = $props();
76
8-
const errorMessage = $derived(error instanceof Error ? error.message : String(error));
9-
const errorStack = $derived(error instanceof Error ? error.stack : null);
7+
// Determine if this is a network/connection error for user-friendly messaging
8+
const isNetworkError = $derived(() => {
9+
const msg = error instanceof Error ? error.message : String(error);
10+
return msg.toLowerCase().includes('network') ||
11+
msg.toLowerCase().includes('fetch') ||
12+
msg.toLowerCase().includes('connection');
13+
});
14+
15+
// User-friendly message - never expose raw error details
16+
const userMessage = $derived(
17+
isNetworkError()
18+
? 'Unable to connect to the server. Please check your internet connection and try again.'
19+
: 'Something went wrong. Our team has been notified and is working on it.'
20+
);
1021
1122
function reload() {
1223
window.location.reload();
@@ -33,21 +44,11 @@
3344
{title}
3445
</h1>
3546

36-
<!-- Error Message -->
37-
<p class="text-center text-red-600 dark:text-red-400 mb-6">
38-
{errorMessage}
47+
<!-- User-friendly Error Message -->
48+
<p class="text-center text-fg-muted dark:text-dark-fg-muted mb-6">
49+
{userMessage}
3950
</p>
4051

41-
<!-- Stack Trace (collapsible) -->
42-
{#if showDetails && errorStack}
43-
<details class="mb-6">
44-
<summary class="cursor-pointer text-sm text-fg-muted dark:text-dark-fg-muted hover:text-fg-default dark:hover:text-dark-fg-default transition-colors">
45-
Show technical details
46-
</summary>
47-
<pre class="mt-2 p-3 bg-code-bg rounded-lg text-xs text-gray-300 overflow-x-auto max-h-48 overflow-y-auto font-mono">{errorStack}</pre>
48-
</details>
49-
{/if}
50-
5152
<!-- Actions -->
5253
<div class="flex flex-col sm:flex-row gap-3">
5354
<button
@@ -66,7 +67,7 @@
6667

6768
<!-- Help Text -->
6869
<p class="mt-6 text-xs text-center text-fg-muted dark:text-dark-fg-muted">
69-
If this problem persists, please check the browser console for more details.
70+
If this problem persists, please contact support.
7071
</p>
7172
</div>
7273
</div>

frontend/src/main.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ window.onerror = (message, source, lineno, colno, error) => {
2222
window.onunhandledrejection = (event) => {
2323
console.error('[Unhandled Promise Rejection]', event.reason);
2424
appError.setError(event.reason, 'Unhandled Promise Error');
25+
event.preventDefault(); // Prevent default handling to match onerror behavior
2526
};
2627

2728
// Mount the app with error handling

0 commit comments

Comments
 (0)