user settings fixes

Author: HardMax71

backend/app/domain/enums/events.py

@@ -34,9 +34,6 @@ class EventType(StringEnum):
 
     # User settings events
     USER_SETTINGS_UPDATED = "user_settings_updated"
-    USER_THEME_CHANGED = "user_theme_changed"
-    USER_NOTIFICATION_SETTINGS_UPDATED = "user_notification_settings_updated"
-    USER_EDITOR_SETTINGS_UPDATED = "user_editor_settings_updated"
 
     # Notification events
     NOTIFICATION_CREATED = "notification_created"

backend/app/domain/enums/kafka.py

@@ -27,9 +27,6 @@ class KafkaTopic(StringEnum):
     USER_EVENTS = "user_events"
     USER_NOTIFICATIONS = "user_notifications"
     USER_SETTINGS_EVENTS = "user_settings_events"
-    USER_SETTINGS_THEME_EVENTS = "user_settings_theme_events"
-    USER_SETTINGS_NOTIFICATION_EVENTS = "user_settings_notification_events"
-    USER_SETTINGS_EDITOR_EVENTS = "user_settings_editor_events"
 
     # Script topics
     SCRIPT_EVENTS = "script_events"

backend/app/infrastructure/kafka/events/__init__.py

@@ -57,13 +57,10 @@
 )
 from app.infrastructure.kafka.events.user import (
     UserDeletedEvent,
-    UserEditorSettingsUpdatedEvent,
     UserLoggedInEvent,
     UserLoggedOutEvent,
-    UserNotificationSettingsUpdatedEvent,
     UserRegisteredEvent,
     UserSettingsUpdatedEvent,
-    UserThemeChangedEvent,
     UserUpdatedEvent,
 )
 
@@ -96,9 +93,6 @@
     "UserUpdatedEvent",
     "UserDeletedEvent",
     "UserSettingsUpdatedEvent",
-    "UserThemeChangedEvent",
-    "UserNotificationSettingsUpdatedEvent",
-    "UserEditorSettingsUpdatedEvent",
     # Notification
     "NotificationCreatedEvent",
     "NotificationSentEvent",

backend/app/infrastructure/kafka/events/base.py

@@ -3,7 +3,7 @@
 from uuid import uuid4
 
 from pydantic import ConfigDict, Field, field_serializer
-from pydantic_avro import AvroBase  # type: ignore[attr-defined]
+from pydantic_avro.to_avro.base import AvroBase
 
 from app.domain.enums.events import EventType
 from app.domain.enums.kafka import KafkaTopic

backend/app/infrastructure/kafka/events/user.py

@@ -1,11 +1,34 @@
 from typing import ClassVar, Literal
 
-from app.domain.enums.auth import LoginMethod, SettingsType
+from pydantic_avro.to_avro.base import AvroBase
+
+from app.domain.enums.auth import LoginMethod
 from app.domain.enums.events import EventType
 from app.domain.enums.kafka import KafkaTopic
 from app.infrastructure.kafka.events.base import BaseEvent
 
 
+class NotificationSettingsPayload(AvroBase):
+    """Avro-compatible payload for notification settings changes."""
+
+    execution_completed: bool | None = None
+    execution_failed: bool | None = None
+    system_updates: bool | None = None
+    security_alerts: bool | None = None
+    channels: list[str] | None = None
+
+
+class EditorSettingsPayload(AvroBase):
+    """Avro-compatible payload for editor settings changes."""
+
+    theme: str | None = None
+    font_size: int | None = None
+    tab_size: int | None = None
+    use_tabs: bool | None = None
+    word_wrap: bool | None = None
+    show_line_numbers: bool | None = None
+
+
 class UserRegisteredEvent(BaseEvent):
     event_type: Literal[EventType.USER_REGISTERED] = EventType.USER_REGISTERED
     topic: ClassVar[KafkaTopic] = KafkaTopic.USER_EVENTS
@@ -47,31 +70,17 @@ class UserDeletedEvent(BaseEvent):
 
 
 class UserSettingsUpdatedEvent(BaseEvent):
+    """Unified event for all user settings changes with typed payloads."""
+
     event_type: Literal[EventType.USER_SETTINGS_UPDATED] = EventType.USER_SETTINGS_UPDATED
     topic: ClassVar[KafkaTopic] = KafkaTopic.USER_SETTINGS_EVENTS
     user_id: str
-    settings_type: SettingsType
-    updated: dict[str, str]
-
-
-class UserThemeChangedEvent(BaseEvent):
-    event_type: Literal[EventType.USER_THEME_CHANGED] = EventType.USER_THEME_CHANGED
-    topic: ClassVar[KafkaTopic] = KafkaTopic.USER_SETTINGS_THEME_EVENTS
-    user_id: str
-    old_theme: str
-    new_theme: str
-
-
-class UserNotificationSettingsUpdatedEvent(BaseEvent):
-    event_type: Literal[EventType.USER_NOTIFICATION_SETTINGS_UPDATED] = EventType.USER_NOTIFICATION_SETTINGS_UPDATED
-    topic: ClassVar[KafkaTopic] = KafkaTopic.USER_SETTINGS_NOTIFICATION_EVENTS
-    user_id: str
-    settings: dict[str, bool]
-    channels: list[str] | None = None
-
-
-class UserEditorSettingsUpdatedEvent(BaseEvent):
-    event_type: Literal[EventType.USER_EDITOR_SETTINGS_UPDATED] = EventType.USER_EDITOR_SETTINGS_UPDATED
-    topic: ClassVar[KafkaTopic] = KafkaTopic.USER_SETTINGS_EDITOR_EVENTS
-    user_id: str
-    settings: dict[str, str | int | bool]
+    changed_fields: list[str]
+    # Typed fields for each settings category (Avro-compatible)
+    theme: str | None = None
+    timezone: str | None = None
+    date_format: str | None = None
+    time_format: str | None = None
+    notifications: NotificationSettingsPayload | None = None
+    editor: EditorSettingsPayload | None = None
+    reason: str | None = None

backend/app/infrastructure/kafka/mappings.py

@@ -60,13 +60,10 @@
 )
 from app.infrastructure.kafka.events.user import (
     UserDeletedEvent,
-    UserEditorSettingsUpdatedEvent,
     UserLoggedInEvent,
     UserLoggedOutEvent,
-    UserNotificationSettingsUpdatedEvent,
     UserRegisteredEvent,
     UserSettingsUpdatedEvent,
-    UserThemeChangedEvent,
     UserUpdatedEvent,
 )
 
@@ -99,9 +96,6 @@ def get_event_class_for_type(event_type: EventType) -> Type[BaseEvent] | None:
         EventType.USER_UPDATED: UserUpdatedEvent,
         EventType.USER_DELETED: UserDeletedEvent,
         EventType.USER_SETTINGS_UPDATED: UserSettingsUpdatedEvent,
-        EventType.USER_THEME_CHANGED: UserThemeChangedEvent,
-        EventType.USER_NOTIFICATION_SETTINGS_UPDATED: UserNotificationSettingsUpdatedEvent,
-        EventType.USER_EDITOR_SETTINGS_UPDATED: UserEditorSettingsUpdatedEvent,
         # Notification events
         EventType.NOTIFICATION_CREATED: NotificationCreatedEvent,
         EventType.NOTIFICATION_SENT: NotificationSentEvent,

backend/app/infrastructure/kafka/topics.py

@@ -127,30 +127,6 @@ def get_topic_configs() -> dict[KafkaTopic, dict[str, Any]]:
                 "compression.type": "gzip",
             },
         },
-        KafkaTopic.USER_SETTINGS_THEME_EVENTS: {
-            "num_partitions": 3,
-            "replication_factor": 1,
-            "config": {
-                "retention.ms": "2592000000",  # 30 days
-                "compression.type": "gzip",
-            },
-        },
-        KafkaTopic.USER_SETTINGS_NOTIFICATION_EVENTS: {
-            "num_partitions": 3,
-            "replication_factor": 1,
-            "config": {
-                "retention.ms": "2592000000",  # 30 days
-                "compression.type": "gzip",
-            },
-        },
-        KafkaTopic.USER_SETTINGS_EDITOR_EVENTS: {
-            "num_partitions": 3,
-            "replication_factor": 1,
-            "config": {
-                "retention.ms": "2592000000",  # 30 days
-                "compression.type": "gzip",
-            },
-        },
         # Script topics
         KafkaTopic.SCRIPT_EVENTS: {
             "num_partitions": 3,