test scope fixes

Author: HardMax71

.github/workflows/backend-ci.yml

@@ -49,7 +49,7 @@ jobs:
         run: |
           cd backend
           uv run pytest tests/unit -v -rs \
-            --cov=app --cov-branch \
+            --cov=app \
             --cov-report=xml --cov-report=term
 
       - name: Upload coverage to Codecov
@@ -146,7 +146,7 @@ jobs:
           cd backend
           uv run pytest tests/integration -v -rs \
             --ignore=tests/integration/k8s \
-            --cov=app --cov-branch \
+            --cov=app \
             --cov-report=xml --cov-report=term
 
       - name: Upload coverage to Codecov
@@ -267,7 +267,7 @@ jobs:
         run: |
           cd backend
           uv run pytest tests/integration/k8s -v -rs \
-            --cov=app --cov-branch \
+            --cov=app \
             --cov-report=xml --cov-report=term
 
       - name: Upload coverage to Codecov

backend/pyproject.toml

@@ -202,7 +202,7 @@ markers = [
     "performance: marks tests as performance tests"
 ]
 asyncio_mode = "auto"
-asyncio_default_fixture_loop_scope = "function"
+asyncio_default_fixture_loop_scope = "session"
 log_cli = false
 log_cli_level = "ERROR"
 log_level = "ERROR"

backend/tests/conftest.py

@@ -126,7 +126,7 @@ def create_test_app():
 
 
 # ===== App without lifespan for tests =====
-@pytest_asyncio.fixture(scope="session", loop_scope="session")
+@pytest_asyncio.fixture(scope="session")
 async def app():
     """Create FastAPI app once per session/worker to avoid Pydantic schema crashes."""
     application = create_test_app()
@@ -138,15 +138,15 @@ async def app():
         await container.close()
 
 
-@pytest_asyncio.fixture(scope="session", loop_scope="session")
+@pytest_asyncio.fixture(scope="session")
 async def app_container(app):  # type: ignore[valid-type]
     """Expose the Dishka container attached to the app."""
     container: AsyncContainer = app.state.dishka_container  # type: ignore[attr-defined]
     return container
 
 
 # ===== Client (function-scoped for clean cookies per test) =====
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def client(app) -> AsyncGenerator[httpx.AsyncClient, None]:  # type: ignore[valid-type]
     # Use httpx with ASGI app directly
     # The app fixture already handles lifespan via LifespanManager
@@ -168,19 +168,19 @@ async def _container_scope(container: AsyncContainer):
         yield scope
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def scope(app_container: AsyncContainer):  # type: ignore[valid-type]
     async with _container_scope(app_container) as s:
         yield s
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def db(scope) -> AsyncGenerator[Database, None]:  # type: ignore[valid-type]
     database: Database = await scope.get(Database)
     yield database
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def redis_client(scope) -> AsyncGenerator[redis.Redis, None]:  # type: ignore[valid-type]
     client: redis.Redis = await scope.get(redis.Redis)
     yield client
@@ -222,7 +222,7 @@ def shared_admin_credentials():
     }
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def shared_user(client: httpx.AsyncClient, shared_user_credentials):
     creds = shared_user_credentials
     # Always attempt to register; DB is wiped after each test
@@ -233,7 +233,7 @@ async def shared_user(client: httpx.AsyncClient, shared_user_credentials):
     return {**creds, "csrf_token": csrf, "headers": {"X-CSRF-Token": csrf}}
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def shared_admin(client: httpx.AsyncClient, shared_admin_credentials):
     creds = shared_admin_credentials
     r = await client.post("/api/v1/auth/register", json=creds)
@@ -243,7 +243,7 @@ async def shared_admin(client: httpx.AsyncClient, shared_admin_credentials):
     return {**creds, "csrf_token": csrf, "headers": {"X-CSRF-Token": csrf}}
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session")
+@pytest_asyncio.fixture
 async def another_user(client: httpx.AsyncClient):
     username = f"test_user_{uuid.uuid4().hex[:8]}"
     email = f"{username}@example.com"

backend/tests/fixtures/real_services.py

@@ -112,7 +112,7 @@ async def cleanup(self):
             await self.kafka_consumer.stop()
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def real_services(request) -> AsyncGenerator[TestServiceConnections, None]:
     """
     Provides real service connections for testing.
@@ -130,7 +130,7 @@ async def real_services(request) -> AsyncGenerator[TestServiceConnections, None]
     await connections.cleanup()
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def real_mongodb(real_services: TestServiceConnections) -> Database:
     """Get real MongoDB database for testing."""
     # Use MongoDB from docker-compose with auth
@@ -139,19 +139,19 @@ async def real_mongodb(real_services: TestServiceConnections) -> Database:
     )
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def real_redis(real_services: TestServiceConnections) -> redis.Redis:
     """Get real Redis client for testing."""
     return await real_services.connect_redis()
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def real_kafka_producer(real_services: TestServiceConnections) -> Optional[AIOKafkaProducer]:
     """Get real Kafka producer if available."""
     return await real_services.connect_kafka_producer("localhost:9092")
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def real_kafka_consumer(real_services: TestServiceConnections) -> Optional[AIOKafkaConsumer]:
     """Get real Kafka consumer if available."""
     test_group = f"test_group_{real_services.test_id}"
@@ -305,7 +305,7 @@ async def wait_for_service(check_func, timeout: int = 30, service_name: str = "s
     raise TimeoutError(f"{service_name} not ready after {timeout}s: {last_error}")
 
 
-@pytest_asyncio.fixture(scope="session", loop_scope="session")
+@pytest_asyncio.fixture(scope="session")
 async def ensure_services_running():
     """Ensure required Docker services are running."""
     import subprocess

backend/tests/integration/conftest.py

@@ -5,21 +5,18 @@
 from app.core.database_context import Database
 
 
-@pytest_asyncio.fixture(scope="function", loop_scope="session", autouse=True)
+@pytest_asyncio.fixture(autouse=True)
 async def _cleanup(db: Database, redis_client: redis.Redis):
-    """Clean DB and Redis before/after each integration test."""
-    # Pre-test cleanup
+    """Clean DB and Redis before each integration test.
+
+    Only pre-test cleanup - post-test cleanup causes event loop issues
+    when SSE/streaming tests hold connections across loop boundaries.
+    """
     collections = await db.list_collection_names()
     for name in collections:
         if not name.startswith("system."):
             await db.drop_collection(name)
     await redis_client.flushdb()
 
     yield
-
-    # Post-test cleanup
-    collections = await db.list_collection_names()
-    for name in collections:
-        if not name.startswith("system."):
-            await db.drop_collection(name)
-    await redis_client.flushdb()
+    # No post-test cleanup to avoid "Event loop is closed" errors

backend/tests/integration/test_user_settings_routes.py

@@ -17,7 +17,7 @@
 pytestmark = pytest.mark.xdist_group(name="user_settings")
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def test_user(client: AsyncClient) -> Dict[str, str]:
     """Create a fresh user for each test."""
     uid = uuid4().hex[:8]
@@ -49,7 +49,7 @@ async def test_user(client: AsyncClient) -> Dict[str, str]:
     }
 
 
-@pytest_asyncio.fixture(loop_scope="session")
+@pytest_asyncio.fixture
 async def test_user2(client: AsyncClient) -> Dict[str, str]:
     """Create a second fresh user for isolation tests."""
     uid = uuid4().hex[:8]