mypy+ruff fixes

Author: HardMax71

backend/app/api/routes/admin/events.py

@@ -33,6 +33,7 @@ def _to_event_filter(pydantic_filter: AdminEventFilter) -> EventFilter:
     data["text_search"] = data.pop("search_text", None)
     return EventFilter(**data)
 
+
 router = APIRouter(
     prefix="/admin/events", tags=["admin-events"], route_class=DishkaRoute, dependencies=[Depends(admin_user)]
 )

backend/app/api/routes/admin/settings.py

@@ -11,6 +11,8 @@
     LogLevel,
     MonitoringSettings,
     SecuritySettings,
+)
+from app.domain.admin import (
     SystemSettings as DomainSystemSettings,
 )
 from app.schemas_pydantic.admin_settings import SystemSettings

backend/app/api/routes/dlq.py

@@ -73,7 +73,7 @@ async def get_dlq_message(event_id: str, repository: FromDishka[DLQRepository])
 
     return DLQMessageDetail(
         event_id=message.event_id or "unknown",
-        event=message.event.to_dict(),
+        event=message.event,  # Already a dict from Document
         event_type=message.event_type,
         original_topic=message.original_topic,
         error=message.error,

backend/app/core/database_context.py

@@ -235,7 +235,7 @@ async def create_connection(self, key: str, config: DatabaseConfig) -> AsyncData
         if key in self._connections:
             raise DatabaseAlreadyInitializedError(f"Connection '{key}' already exists")
 
-        connection = AsyncDatabaseConnection(config)
+        connection = AsyncDatabaseConnection(config, self.logger)
         await connection.connect()
         self._connections[key] = connection
         return connection

backend/app/core/logging.py

@@ -7,7 +7,6 @@
 
 from opentelemetry import trace
 
-
 correlation_id_context: contextvars.ContextVar[str | None] = contextvars.ContextVar("correlation_id", default=None)
 
 request_metadata_context: contextvars.ContextVar[Dict[str, Any] | None] = contextvars.ContextVar(

backend/app/core/providers.py

@@ -176,7 +176,9 @@ async def get_kafka_producer(
             await producer.stop()
 
     @provide
-    async def get_dlq_manager(self, schema_registry: SchemaRegistryManager, logger: logging.Logger) -> AsyncIterator[DLQManager]:
+    async def get_dlq_manager(
+        self, schema_registry: SchemaRegistryManager, logger: logging.Logger
+    ) -> AsyncIterator[DLQManager]:
         manager = create_dlq_manager(schema_registry, logger)
         await manager.start()
         try:
@@ -189,7 +191,9 @@ def get_idempotency_repository(self, redis_client: redis.Redis) -> RedisIdempote
         return RedisIdempotencyRepository(redis_client, key_prefix="idempotency")
 
     @provide
-    async def get_idempotency_manager(self, repo: RedisIdempotencyRepository, logger: logging.Logger) -> AsyncIterator[IdempotencyManager]:
+    async def get_idempotency_manager(
+        self, repo: RedisIdempotencyRepository, logger: logging.Logger
+    ) -> AsyncIterator[IdempotencyManager]:
         manager = create_idempotency_manager(repository=repo, config=IdempotencyConfig(), logger=logger)
         await manager.initialize()
         try:
@@ -212,7 +216,11 @@ async def get_event_store(self, schema_registry: SchemaRegistryManager, logger:
 
     @provide
     async def get_event_store_consumer(
-        self, event_store: EventStore, schema_registry: SchemaRegistryManager, kafka_producer: UnifiedProducer, logger: logging.Logger
+        self,
+        event_store: EventStore,
+        schema_registry: SchemaRegistryManager,
+        kafka_producer: UnifiedProducer,
+        logger: logging.Logger,
     ) -> EventStoreConsumer:
         topics = get_all_topics()
         return create_event_store_consumer(
@@ -532,7 +540,10 @@ def get_saga_service(
         logger: logging.Logger,
     ) -> SagaService:
         return SagaService(
-            saga_repo=saga_repository, execution_repo=execution_repository, orchestrator=saga_orchestrator, logger=logger
+            saga_repo=saga_repository,
+            execution_repo=execution_repository,
+            orchestrator=saga_orchestrator,
+            logger=logger,
         )
 
     @provide
@@ -545,16 +556,26 @@ def get_execution_service(
         logger: logging.Logger,
     ) -> ExecutionService:
         return ExecutionService(
-            execution_repo=execution_repository, producer=kafka_producer, event_store=event_store, settings=settings, logger=logger
+            execution_repo=execution_repository,
+            producer=kafka_producer,
+            event_store=event_store,
+            settings=settings,
+            logger=logger,
         )
 
     @provide
-    def get_saved_script_service(self, saved_script_repository: SavedScriptRepository, logger: logging.Logger) -> SavedScriptService:
+    def get_saved_script_service(
+        self, saved_script_repository: SavedScriptRepository, logger: logging.Logger
+    ) -> SavedScriptService:
         return SavedScriptService(saved_script_repository, logger)
 
     @provide
     async def get_replay_service(
-        self, replay_repository: ReplayRepository, kafka_producer: UnifiedProducer, event_store: EventStore, logger: logging.Logger
+        self,
+        replay_repository: ReplayRepository,
+        kafka_producer: UnifiedProducer,
+        event_store: EventStore,
+        logger: logging.Logger,
     ) -> ReplayService:
         event_replay_service = EventReplayService(
             repository=replay_repository, producer=kafka_producer, event_store=event_store, logger=logger

backend/app/core/security.py

@@ -6,12 +6,8 @@
 from fastapi.security import OAuth2PasswordBearer
 from passlib.context import CryptContext
 
-from app.domain.user import (
-    AuthenticationRequiredError,
-    CSRFValidationError,
-    InvalidCredentialsError,
-    User as DomainAdminUser,
-)
+from app.domain.user import AuthenticationRequiredError, CSRFValidationError, InvalidCredentialsError
+from app.domain.user import User as DomainAdminUser
 from app.settings import get_settings
 
 oauth2_scheme = OAuth2PasswordBearer(tokenUrl="/api/v1/login")

backend/app/db/docs/dlq.py

@@ -56,4 +56,5 @@ class Settings:
     @property
     def age_seconds(self) -> float:
         """Get message age in seconds since failure."""
-        return (datetime.now(timezone.utc) - self.failed_at).total_seconds()
+        failed_at: datetime = self.failed_at
+        return (datetime.now(timezone.utc) - failed_at).total_seconds()

backend/app/db/docs/execution.py

@@ -1,5 +1,4 @@
 from datetime import datetime, timezone
-from typing import Any
 from uuid import uuid4
 
 from beanie import Document, Indexed
@@ -16,9 +15,7 @@ class ResourceUsage(BaseModel):
     Copied from execution.py ResourceUsage.
     """
 
-    execution_time_wall_seconds: float | None = Field(
-        default=None, description="Wall clock execution time in seconds"
-    )
+    execution_time_wall_seconds: float | None = Field(default=None, description="Wall clock execution time in seconds")
     cpu_time_jiffies: int | None = Field(
         default=None, description="CPU time in jiffies (multiply by 10 for milliseconds)"
     )
@@ -59,5 +56,3 @@ class Settings:
         indexes = [
             IndexModel([("status", 1)]),
         ]
-
-

backend/app/db/docs/notification.py

@@ -105,6 +105,8 @@ class Settings:
         name = "notification_subscriptions"
         use_state_management = True
         indexes = [
-            IndexModel([("user_id", ASCENDING), ("channel", ASCENDING)], name="idx_sub_user_channel_unique", unique=True),
+            IndexModel(
+                [("user_id", ASCENDING), ("channel", ASCENDING)], name="idx_sub_user_channel_unique", unique=True
+            ),
             IndexModel([("enabled", ASCENDING)], name="idx_sub_enabled"),
         ]