Skip to content

Commit da3076b

Browse files
author
Max Azatian
committed
CI fix 1 - simplified creds
1 parent 0ec021c commit da3076b

File tree

1 file changed

+10
-16
lines changed

1 file changed

+10
-16
lines changed

.github/workflows/tests.yml

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@ jobs:
3232
kubectl version
3333
kubectl get nodes
3434
35-
- name: Set Mongo credentials from secrets
36-
run: |
37-
# Export for docker compose variable interpolation and yq usage
38-
echo "MONGO_ROOT_USER=${{ secrets.MONGO_ROOT_USER }}" >> $GITHUB_ENV
39-
echo "MONGO_ROOT_PASSWORD=${{ secrets.MONGO_ROOT_PASSWORD }}" >> $GITHUB_ENV
40-
4135
- name: Modify Docker Compose for CI
4236
run: |
4337
cp docker-compose.yaml docker-compose.ci.yaml
@@ -46,14 +40,13 @@ jobs:
4640
# For the backend service (extra_hosts already exists, skip it)
4741
# Note: backend.environment is a list in docker-compose.yaml
4842
yq eval '.services.backend.environment += ["TESTING=true"]' -i docker-compose.ci.yaml
49-
yq eval '.services.backend.environment += ["MONGO_ROOT_USER=" + env(MONGO_ROOT_USER)]' -i docker-compose.ci.yaml
50-
yq eval '.services.backend.environment += ["MONGO_ROOT_PASSWORD=" + env(MONGO_ROOT_PASSWORD)]' -i docker-compose.ci.yaml
43+
yq eval '.services.backend.environment += ["MONGO_ROOT_USER=root"]' -i docker-compose.ci.yaml
44+
yq eval '.services.backend.environment += ["MONGO_ROOT_PASSWORD=rootpassword"]' -i docker-compose.ci.yaml
5145
# Disable OpenTelemetry SDK during tests to avoid exporter retries
5246
yq eval '.services.backend.environment += ["OTEL_SDK_DISABLED=true"]' -i docker-compose.ci.yaml
5347
54-
# For the mongo service (environment is a map, not a list)
55-
yq eval '.services.mongo.environment.MONGO_INITDB_ROOT_USERNAME = env(MONGO_ROOT_USER)' -i docker-compose.ci.yaml
56-
yq eval '.services.mongo.environment.MONGO_INITDB_ROOT_PASSWORD = env(MONGO_ROOT_PASSWORD)' -i docker-compose.ci.yaml
48+
# MongoDB service already has defaults in docker-compose.yaml (root/rootpassword)
49+
# No need to override them
5750
5851
# Disable SASL authentication for Kafka and Zookeeper in CI
5952
yq eval 'del(.services.kafka.environment.KAFKA_OPTS)' -i docker-compose.ci.yaml
@@ -139,16 +132,17 @@ jobs:
139132
- name: Run backend tests with coverage
140133
env:
141134
BACKEND_BASE_URL: https://127.0.0.1:443
142-
# Pass credentials separately to let Python handle URL encoding
143-
MONGO_ROOT_USER: ${{ secrets.MONGO_ROOT_USER }}
144-
MONGO_ROOT_PASSWORD: ${{ secrets.MONGO_ROOT_PASSWORD }}
135+
# Use default MongoDB credentials for CI
136+
MONGO_ROOT_USER: root
137+
MONGO_ROOT_PASSWORD: rootpassword
145138
MONGODB_HOST: 127.0.0.1
146139
MONGODB_PORT: 27017
147-
# Don't set MONGODB_URL here - let conftest.py construct it with proper encoding
140+
# Explicit URL with default credentials
141+
MONGODB_URL: mongodb://root:[email protected]:27017/?authSource=admin
148142
run: |
149143
cd backend
150144
echo "Using BACKEND_BASE_URL=$BACKEND_BASE_URL"
151-
echo "MongoDB connection will use host: 127.0.0.1:27017"
145+
echo "MongoDB connection will use default CI credentials"
152146
python -m pytest tests/integration tests/unit -v --cov=app --cov-branch --cov-report=xml --cov-report=term --cov-report=term-missing
153147
154148
- name: Upload coverage to Codecov

0 commit comments

Comments
 (0)