Fix

Author: Hardvan

src/test/java/com/thealgorithms/maths/ConvolutionTest.java

@@ -2,73 +2,26 @@
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 
-import org.junit.jupiter.api.Test;
+import java.util.stream.Stream;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
 
 public class ConvolutionTest {
 
-    @Test
-    public void testConvolutionBasic() {
-        double[] signalA = {1, 2, 3};
-        double[] signalB = {4, 5, 6};
-        double[] expected = {4, 13, 28, 27, 18}; // Expected output
-
-        double[] result = Convolution.convolution(signalA, signalB);
-
-        assertArrayEquals(expected, result, 1e-9); // Allowing for floating-point precision
-    }
-
-    @Test
-    public void testConvolutionWithZeroElements() {
-        double[] signalA = {0, 0, 0};
-        double[] signalB = {1, 2, 3};
-        double[] expected = {0, 0, 0, 0, 0}; // All values should remain zero
-
-        double[] result = Convolution.convolution(signalA, signalB);
-
-        assertArrayEquals(expected, result, 1e-9);
-    }
-
-    @Test
-    public void testConvolutionSingleElement() {
-        double[] signalA = {2};
-        double[] signalB = {3};
-        double[] expected = {6}; // 2 * 3 = 6
-
-        double[] result = Convolution.convolution(signalA, signalB);
-
-        assertArrayEquals(expected, result, 1e-9);
+    record ConvolutionTestCase(String description, double[] signalA, double[] signalB, double[] expected) {
     }
 
-    @Test
-    public void testConvolutionWithDifferentSizes() {
-        double[] signalA = {1, 2};
-        double[] signalB = {3, 4, 5};
-        double[] expected = {3, 10, 13, 10}; // Expected output
-
-        double[] result = Convolution.convolution(signalA, signalB);
-
-        assertArrayEquals(expected, result, 1e-9);
+    @ParameterizedTest(name = "{0}")
+    @MethodSource("provideTestCases")
+    void testConvolution(ConvolutionTestCase testCase) {
+        double[] result = Convolution.convolution(testCase.signalA, testCase.signalB);
+        assertArrayEquals(testCase.expected, result, 1e-9, testCase.description);
     }
 
-    @Test
-    public void testConvolutionWithNegativeValues() {
-        double[] signalA = {1, -2, 3};
-        double[] signalB = {-1, 2, -3};
-        double[] expected = {-1, 4, -10, 12, -9}; // Expected output
-
-        double[] result = Convolution.convolution(signalA, signalB);
-
-        assertArrayEquals(expected, result, 1e-9);
-    }
-
-    @Test
-    public void testConvolutionWithLargeNumbers() {
-        double[] signalA = {1e6, 2e6};
-        double[] signalB = {3e6, 4e6};
-        double[] expected = {3e12, 1e13, 8e12}; // Expected output with large numbers
-
-        double[] result = Convolution.convolution(signalA, signalB);
-
-        assertArrayEquals(expected, result, 1e-9);
+    private static Stream<ConvolutionTestCase> provideTestCases() {
+        return Stream.of(new ConvolutionTestCase("Basic convolution", new double[] {1, 2, 3}, new double[] {4, 5, 6}, new double[] {4, 13, 28, 27, 18}), new ConvolutionTestCase("Convolution with zero elements", new double[] {0, 0, 0}, new double[] {1, 2, 3}, new double[] {0, 0, 0, 0, 0}),
+            new ConvolutionTestCase("Convolution with single element", new double[] {2}, new double[] {3}, new double[] {6}), new ConvolutionTestCase("Convolution with different sizes", new double[] {1, 2}, new double[] {3, 4, 5}, new double[] {3, 10, 13, 10}),
+            new ConvolutionTestCase("Convolution with negative values", new double[] {1, -2, 3}, new double[] {-1, 2, -3}, new double[] {-1, 4, -10, 12, -9}),
+            new ConvolutionTestCase("Convolution with large numbers", new double[] {1e6, 2e6}, new double[] {3e6, 4e6}, new double[] {3e12, 1e13, 8e12}));
     }
 }