Move ASCII_LOGO.txt to source string #24
Description
Feature Summary
We are incurring an unnecessary perf cost using FS calls for the ASCII_LOGO.txt file. It's just text, so let's move it to the actual source code (as a string variable).
Problem This Solves
- One less static path to resolve
- One less FS operation to do
Proposed Solution
Move the contents of the file to a multi-line string in hdbTerms.ts or something else.
User Stories
No response
Alternatives Considered
No response
Priority/Impact
Low - nice to have
Examples or References
No response
Additional Context
We are still figuring out our overall testing strategy (#22), but this should be tested as part of some sort of "Harper Installation Flow" integration test. We don't really have a solution for that yet, but I'd love to consider one here or as part of follow-up work. Most likely we should consider how to do general CLI integration testing. I'd prefer we lever Node.js test runner still and do something along the lines of using child_process.exec to run CLI commands and then build assertions around the std streams and file system outputs.
Are you planning to fix this issue?
Yes, I'll submit a PR to fix this
First-time contributor support
- I'm new to contributing and would appreciate guidance on the process
- I'd like help understanding the project structure
- I need assistance with setting up the development environment
- I'm comfortable contributing, but new to this project specifically