Restore compression with lmdb, code cleanup

Author: kriszyp

.github/workflows/benchmark.yml

@@ -77,7 +77,7 @@ jobs:
       - name: Run benchmarks
         env:
           BENCHMARK_MODE: ${{ github.event.inputs.mode || 'essential' }}
-        run: pnpm bench --passWithNoTests
+        run: pnpm bench
 
       - name: Upload benchmark results as artifact
         if: always() && hashFiles('benchmark-results.json') != ''

benchmark/realistic-load.bench.ts

@@ -6,7 +6,6 @@ import {
 	type LMDBDatabase
 } from './setup.js';
 import type { RocksDatabase } from '../dist/index.mjs';
-import { threadId } from 'worker_threads';
 
 const DELETE_RATIO = 0.2;
 const NUM_KEYS = 5_000;
@@ -25,7 +24,6 @@ describe('Realistic write load with workers', () => {
 				ctx.log = log;
 			},
 			async bench({ db, log }) {
-				let id = Math.random();
 				for (let i = 0; i < ITERATIONS; i++) {
 					await db.transaction((txn) => {
 						const key = Math.floor(Math.random() * NUM_KEYS).toString();

benchmark/setup.ts

@@ -1,5 +1,4 @@
 import { RocksDatabase, RocksDatabaseOptions } from '../dist/index.mjs';
-import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import * as lmdb from 'lmdb';
 import { randomBytes } from 'node:crypto';
@@ -68,7 +67,7 @@ export function benchmark(type: string, options: any): void {
 				if (type === 'rocksdb') {
 					ctx = { db: RocksDatabase.open(dbPath, dbOptions), mode };
 				} else {
-					ctx = { db: lmdb.open({ path: dbPath, ...dbOptions }), mode };
+					ctx = { db: lmdb.open({ path: dbPath, compression: true, ...dbOptions }), mode };
 				}
 			}
 			if (typeof setup === 'function') {

package.json

@@ -15,7 +15,7 @@
   "type": "module",
   "gypfile": true,
   "scripts": {
-    "bench": "cross-env CI=1 vitest bench --outputJson benchmark-results.json",
+    "bench": "cross-env CI=1 vitest bench --passWithNoTests --outputJson benchmark-results.json",
     "bench:bun": "cross-env CI=1 bun --bun bench",
     "bench:deno": "cross-env CI=1 deno run --allow-all --sloppy-imports ./node_modules/vitest/vitest.mjs bench",
     "build": "pnpm build:bundle && pnpm rebuild",