fix: Worked through all oxlint suggestions

dawsontoth · dawsontoth · commit 0ff616aac1de · 2025-12-09T18:38:29.000Z
diff --git a/deploy-template/fastify/static.js b/deploy-template/fastify/static.js
@@ -1,7 +1,7 @@
 import fastifyStatic from '@fastify/static';
 import { join } from 'path';
 
-export default async (fastify, { hdbCore, logger }) => {
+export default async (fastify) => {
 	fastify.register(fastifyStatic, {
 		root: join(import.meta.dirname, '../web'),
 		maxAge: '30d',
diff --git a/src/components/Breadcrumbs.tsx b/src/components/Breadcrumbs.tsx
@@ -21,7 +21,7 @@ export function Breadcrumbs({ restartRequired }: { restartRequired?: boolean })
 			.filter((x) => x && x.length > 0);
 
 		const breadcrumbs = [
-			<Link to="/">
+			<Link key="home" to="/">
 				<HomeIcon aria-hidden="true" className="size-5 shrink-0" />
 				<span className="sr-only">Home</span>
 			</Link>,
@@ -35,7 +35,7 @@ export function Breadcrumbs({ restartRequired }: { restartRequired?: boolean })
 
 			let path = `/${routeHistory.slice(0, index + 1).join('/')}`;
 			let name = capitalizeWords(route);
-			let id: string | undefined;
+			let id: string | undefined = undefined;
 			if (route === 'databases' && routeHistory.length === index + 3) {
 				// id = routeHistory[index + 1];
 				name = routeHistory[index + 2];
diff --git a/src/components/ContactUs.tsx b/src/components/ContactUs.tsx
@@ -3,6 +3,7 @@ export function ContactUs({ overEmail }: { readonly overEmail?: boolean }) {
 		<a
 			href={overEmail ? 'mailto:support@harperdb.io' : 'https://discord.com/channels/1415002037439041710/1415002038286286994'}
 			target="_blank"
+			rel="noreferrer"
 			className="underline">
 			Contact us
 		</a>);
diff --git a/src/components/InstanceTypeSelectInput.tsx b/src/components/InstanceTypeSelectInput.tsx
diff --git a/src/components/ui/sidebar/SidebarProvider.tsx b/src/components/ui/sidebar/SidebarProvider.tsx
diff --git a/src/features/auth/ClusterInstanceSignIn.tsx b/src/features/auth/ClusterInstanceSignIn.tsx
@@ -149,10 +149,11 @@ export function ClusterInstanceSignIn() {
 										<li>Is the server running?</li>
 										<li>Have you <a
 											href="https://docs.harperdb.io/docs/developers/security/configuration#cors" target="_blank"
+											rel="noreferrer"
 											className="underline">enabled CORS</a> for the operations API?
 										</li>
 										{warnAboutLocalDeviceAccess && <li>Have you allowed <a
-											href="https://www.google.com/search?q=How+do+I+enable+local+network+access+in+my+browser%3F" className="underline" target="_blank">local
+											href="https://www.google.com/search?q=How+do+I+enable+local+network+access+in+my+browser%3F" className="underline" target="_blank" rel="noreferrer">local
 											network access</a> in your browser?</li>}
 									</ol>
 								</div>
diff --git a/src/features/auth/SignUp.tsx b/src/features/auth/SignUp.tsx
@@ -187,9 +187,9 @@ export function SignUp() {
 						)}
 					/>
 					<p className="text-xs">By creating an account, you agree to
-						the <a rel="noopener" href="https://www.harper.fast/resources/privacy-policy" target="_blank" className="underline hover:text-blue-300">
+						the <a href="https://www.harper.fast/resources/privacy-policy" target="_blank" rel="noreferrer" className="underline hover:text-blue-300">
 							Privacy Policy
-						</a> and <a rel="noopener" href="https://www.harper.fast/resources/terms-of-use" target="_blank" className="underline hover:text-blue-300">
+						</a> and <a href="https://www.harper.fast/resources/terms-of-use" target="_blank" rel="noreferrer" className="underline hover:text-blue-300">
 							Terms of Service
 						</a></p>
 
diff --git a/src/features/cluster/Scaling.tsx b/src/features/cluster/Scaling.tsx
@@ -49,7 +49,7 @@ export function Scaling() {
 				<p>Your cluster is updating with the latest changes. This includes waiting several minutes to let
 					traffic drain safely. <span className="text-muted-foreground">
 						We will let you know when we are ready for you to connect! In the meantime, join us
-						on <a href="https://discord.gg/VzZuaw3Xay" target="_blank">Discord</a>! Get real-time help from our
+						on <a href="https://discord.gg/VzZuaw3Xay" target="_blank" rel="noreferrer">Discord</a>! Get real-time help from our
 						engineers, see feature drops early, and connect with others building on Fabric.</span>
 				</p>
 			</div>
diff --git a/src/features/cluster/StartingUp.tsx b/src/features/cluster/StartingUp.tsx
@@ -93,7 +93,7 @@ export function StartingUp() {
 				<p>Your cluster is spinning up with the latest changes, including your own DNS records and private
 					connections. Please wait while we get everything going. <span className="text-muted-foreground">
 						We will let you know when we are ready for you to connect! In the meantime, join us
-						on <a href="https://discord.gg/VzZuaw3Xay" target="_blank">Discord</a>! Get real-time help from our
+						on <a href="https://discord.gg/VzZuaw3Xay" target="_blank" rel="noreferrer">Discord</a>! Get real-time help from our
 						engineers, see feature drops early, and connect with others building on Fabric.</span>
 				</p>
 			</div>
diff --git a/src/features/clusters/components/ClusterCard.tsx b/src/features/clusters/components/ClusterCard.tsx
@@ -128,42 +128,42 @@ export function ClusterCard({ cluster }: { cluster: Cluster; }) {
 
 	const menuItems = [
 		isActive && update && !auth.isLoading && (!isDirectConnect || isFabricConnect) && (
-			<Link to={`${cluster.id}/sign-in`} disabled={signingOut}>
+			<Link key="sign-in" to={`${cluster.id}/sign-in`} disabled={signingOut}>
 				<DropdownMenuItem>Direct Sign In</DropdownMenuItem>
 			</Link>
 		),
 		isActive && update && (
-			<Link to={`${cluster.id}/edit`} disabled={signingOut}>
+			<Link key="edit" to={`${cluster.id}/edit`} disabled={signingOut}>
 				<DropdownMenuItem>Edit</DropdownMenuItem>
 			</Link>
 		),
 		isActive && view && (
-			<Link to={`${cluster.id}/instances`} disabled={signingOut}>
+			<Link key="instances" to={`${cluster.id}/instances`} disabled={signingOut}>
 				<DropdownMenuItem>Instances</DropdownMenuItem>
 			</Link>
 		),
 		isActive && view && cluster.fqdn && (
-			<DropdownMenuItem onClick={onCopyFQDNClick} disabled={signingOut}>
+			<DropdownMenuItem key="copy-host-name" onClick={onCopyFQDNClick} disabled={signingOut}>
 				Copy Host Name
 			</DropdownMenuItem>
 		),
 		isActive && view && cluster.fqdn && (
-			<DropdownMenuItem onClick={onCopyAPIClick} disabled={signingOut}>
+			<DropdownMenuItem key="copy-api-url" onClick={onCopyAPIClick} disabled={signingOut}>
 				Copy API URL
 			</DropdownMenuItem>
 		),
 		isActive && view && !!operationsUrl && !auth.isLoading && isDirectConnect && (
-			<DropdownMenuItem onClick={onSignOutClick} disabled={signingOut}>
+			<DropdownMenuItem key="direct-sign-out" onClick={onSignOutClick} disabled={signingOut}>
 				Direct Sign Out
 			</DropdownMenuItem>
 		),
 		clusterHasFailed && create && (
-			<DropdownMenuItem className="focus:bg-green/70 focus:text-white" onClick={onTryAgainClick}>
+			<DropdownMenuItem key="try-again" className="focus:bg-green/70 focus:text-white" onClick={onTryAgainClick}>
 				Try Again
 			</DropdownMenuItem>
 		),
 		!isTerminated && remove && (
-			<DropdownMenuItem className="focus:bg-red/70 focus:text-white" onClick={onTerminateClick}>
+			<DropdownMenuItem key="remove" className="focus:bg-red/70 focus:text-white" onClick={onTerminateClick}>
 				{isSelfManaged ? 'Remove' : 'Terminate'}
 			</DropdownMenuItem>
 		),
diff --git a/src/features/instance/applications/components/NewApplication/ImportInstructions.tsx b/src/features/instance/applications/components/NewApplication/ImportInstructions.tsx
@@ -175,7 +175,7 @@ export function ImportInstructions({
 										to="config" className="underline">Config</Link> &gt; <Link
 										to="config/ssh-keys" className="underline">SSH Keys</Link>. This enables SSH based auth for private
 										repos, i.e. following the pattern of <a
-										href="https://github.com/HarperFast/Studio" target="_blank" className="underline">git@github.com:HarperFast/studio.git</a>.
+										href="https://github.com/HarperFast/Studio" target="_blank" rel="noreferrer" className="underline">git@github.com:HarperFast/studio.git</a>.
 										If you have more than one key, make sure to utilize unique hostnames!
 									</span>
 								</AlertDescription>
diff --git a/src/features/instance/status/Status.tsx b/src/features/instance/status/Status.tsx
@@ -8,12 +8,12 @@ export function Status({ data }: { data: Record<string, unknown> }) {
 		{items.map((item, index) =>
 			hasTitle(item) ? (
 				<div key={index} className={cn('font-semibold text-xl', index !== 0 && 'mt-4')} style={{ paddingLeft: item.depth * 12 + 'px' }}>{item.title}</div>
-			) : (<>
+			) : (
 				<div key={index} style={{ paddingLeft: item.depth * 12 + 'px' }}>
 					<span className="text-muted-foreground">{item.name}: </span>
 					{item.value}
 				</div>
-			</>),
+			),
 		)}
 	</div>;
 }
