Skip to content

Commit 26a2cdb

Browse files
committed
feat: Add ids and names to all forms
https://harperdb.atlassian.net/browse/STUDIO-653
1 parent 5d09e92 commit 26a2cdb

File tree

32 files changed

+185
-31
lines changed

32 files changed

+185
-31
lines changed

src/features/auth/ClusterInstanceSignIn.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,12 @@ export function ClusterInstanceSignIn() {
106106
Sign in to Harper {properNoun}
107107
</h2>
108108
<Form {...methods}>
109-
<form onSubmit={handleSubmit(submitForm)} className="my-4">
109+
<form
110+
id={`auth-${commonNoun}-signin-form`}
111+
name={`auth-${commonNoun}-signin-form`}
112+
onSubmit={handleSubmit(submitForm)}
113+
className="my-4"
114+
>
110115
<FormField
111116
control={control}
112117
name="username"

src/features/auth/ForgotPassword.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,12 @@ export function ForgotPassword() {
5757
<h2 className="text-2xl font-light">Enter your account email</h2>
5858
<p className="text-sm pt-1">If a matching account exists, we'll send you a password reset link.</p>
5959
<Form {...methods}>
60-
<form onSubmit={handleSubmit(submitForm)} className="my-4">
60+
<form
61+
id="auth-forgot-password-form"
62+
name="auth-forgot-password-form"
63+
onSubmit={handleSubmit(submitForm)}
64+
className="my-4"
65+
>
6166
<FormField
6267
control={control}
6368
name="email"

src/features/auth/ResetPassword.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,12 @@ export function ResetPassword() {
7474
<div className="text-white w-xs">
7575
<h2 className="text-2xl font-light">Reset Password</h2>
7676
<Form {...methods}>
77-
<form className="my-4" onSubmit={handleSubmit(submitForm)}>
77+
<form
78+
id="auth-reset-password-form"
79+
name="auth-reset-password-form"
80+
className="my-4"
81+
onSubmit={handleSubmit(submitForm)}
82+
>
7883
<FormField
7984
control={control}
8085
name="password"

src/features/auth/SignIn.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,12 @@ export function SignIn() {
3333
<div className="text-white w-xs">
3434
<h2 className="text-2xl font-light">Sign in to Harper Fabric</h2>
3535
<Form {...methods}>
36-
<form onSubmit={handleSubmit(submitForm)} className="my-4">
36+
<form
37+
id="auth-signin-form"
38+
name="auth-signin-form"
39+
onSubmit={handleSubmit(submitForm)}
40+
className="my-4"
41+
>
3742
<FormField
3843
control={control}
3944
name="email"

src/features/auth/SignUp.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,12 @@ export function SignUp() {
103103
<hr className="border-gray-600" />
104104

105105
<Form {...methods}>
106-
<form onSubmit={handleSubmit(submitForm)} className="grid gap-4 my-4">
106+
<form
107+
id="auth-signup-form"
108+
name="auth-signup-form"
109+
onSubmit={handleSubmit(submitForm)}
110+
className="grid gap-4 my-4"
111+
>
107112
<FormField
108113
control={control}
109114
name="firstname"

src/features/auth/VerifyEmail.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,12 @@ function SendEmailVerification() {
5454
return (
5555
<Form {...methods}>
5656
<p className="text-sm py-2">Please Enter an Email</p>
57-
<form onSubmit={handleSubmit(submitForm)} className="my-4">
57+
<form
58+
id="auth-verify-email-form"
59+
name="auth-verify-email-form"
60+
onSubmit={handleSubmit(submitForm)}
61+
className="my-4"
62+
>
5863
<FormField
5964
control={control}
6065
name="email"

src/features/cluster/FinishSetup.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,20 @@ export function FinishSetup() {
9898
<nav className="fixed top-20 w-full h-12 z-39 px-4 md:px-12 bg-grey-700 flex items-center">
9999
<Breadcrumbs />
100100
</nav>
101-
<div className="items-center justify-center flex mt-32 py-4 min-h-[calc(100vh-theme(spacing.32))]">
101+
<div className="items-center justify-center flex mt-32 py-4 min-h-[calc(100vh-(--spacing(32)))]">
102102
<div className="text-white w-xs">
103103
<h2 className="text-2xl font-light">Create Admin User</h2>
104104
<p className="text-muted-foreground">
105105
You are ready to create your first user in your new cluster. These credentials belong to you alone, and you
106106
can create more users and roles once you create this first one.
107107
</p>
108108
<Form {...methods}>
109-
<form onSubmit={handleSubmit(submitForm)} className="my-4">
109+
<form
110+
id="cluster-create-admin-form"
111+
name="cluster-create-admin-form"
112+
onSubmit={handleSubmit(submitForm)}
113+
className="my-4"
114+
>
110115
<FormField
111116
control={control}
112117
name="username"

src/features/cluster/domains/Management.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,8 @@ export function DomainsManagement() {
131131
{update && (
132132
<Form {...form}>
133133
<form
134+
id="cluster-create-domain-form"
135+
name="cluster-create-domain-form"
134136
onSubmit={form.handleSubmit(onSubmitClick)}
135137
className="flex gap-1 flex-col md:flex-row"
136138
>

src/features/clusters/upsert/ClusterForm.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,11 @@ export function ClusterForm({
463463
Configure your Harper cluster and define deployment plans.
464464
</p>
465465

466-
<form onSubmit={form.handleSubmit(submitClusterDetailsForm)}>
466+
<form
467+
id="cluster-upsert-form"
468+
name="cluster-upsert-form"
469+
onSubmit={form.handleSubmit(submitClusterDetailsForm)}
470+
>
467471
<ClusterDetails
468472
calculatedNames={calculatedNames}
469473
clusterId={clusterId}

src/features/instance/applications/components/NewApplication/index.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,12 @@ export function NewApplication() {
116116
</div>
117117

118118
<Form {...methods}>
119-
<form onSubmit={handleSubmit(submitForm)} className="flex flex-col gap-4 p-4">
119+
<form
120+
id="instance-create-application-form"
121+
name="instance-create-application-form"
122+
onSubmit={handleSubmit(submitForm)}
123+
className="flex flex-col gap-4 p-4"
124+
>
120125
<fieldset disabled={isImportingApplication || isCreatingFromTemplate || isReloading}>
121126
<Card className="bg-black-dark">
122127
<CommonInstructions

0 commit comments

Comments
 (0)