chore: Fix sonar warnings

Author: dawsontoth

src/features/instance/applications/context/EditorViewProvider.tsx

@@ -38,16 +38,11 @@ export function EditorViewProvider({ children }: PropsWithChildren) {
 	const queryClient = useQueryClient();
 	const { open }: { open?: string } = useSearch({ strict: false });
 
-	const reloadRootEntries = useCallback(async () => {
-		// await queryClient.invalidateQueries({
-		// 	queryKey: [instanceParams.entityId, 'get_components'],
-		// 	refetchType: 'active',
-		// });
-		return queryClient.fetchQuery<APIDirectoryEntry>({
+	const reloadRootEntries = useCallback(async () =>
+		queryClient.fetchQuery<APIDirectoryEntry>({
 			queryKey: [instanceParams.entityId, 'get_components'],
 			networkMode: 'online',
-		});
-	}, [queryClient, instanceParams]);
+		}), [queryClient, instanceParams]);
 
 	/*
 	 Create our structured view from the relational API data.

src/features/instance/applications/lib/parseReadMe.ts

@@ -4,10 +4,10 @@ export function parseReadMe(contents: string, baseURL: string, response: GetComp
 	const operations9925URL = baseURL;
 	const rest9926URL = baseURL.replace(':9925', '');
 	if (operations9925URL) {
-		contents = contents.replace(/http:\/\/localhost:9926/g, rest9926URL);
+		contents = contents.replaceAll('http://localhost:9926', rest9926URL);
 	}
 	if (response.project) {
-		contents = contents.replace(/Your New Harper Fabric App/g, response.project);
+		contents = contents.replaceAll('Your New Harper Fabric App', response.project);
 	}
 	return contents;
 }

src/integrations/github/getGitHubRepo.ts

@@ -1,5 +1,5 @@
 export async function getGitHubRepo(url: URL) {
-	if (url && url.pathname && url.hostname.includes('github.com')) {
+	if (url?.pathname && url.hostname.includes('github.com')) {
 		const parts = url.pathname.split('/').filter(Boolean);
 
 		try {

src/integrations/github/getGitHubTags.ts

@@ -3,7 +3,7 @@ export async function getGitHubTags(user: string, repo: string) {
 
 	if (response.status < 400) {
 		const tagData = await response.json();
-		return tagData.map((tag: { ref: string }) => tag.ref.split('/').slice(-1)[0]);
+		return tagData.map((tag: { ref: string }) => tag.ref.split('/').at(1));
 	}
 
 	return [];