Skip to content

Commit c2c6d74

Browse files
committed
fix: Make the requested restart button less confusing
1 parent 42475e7 commit c2c6d74

File tree

1 file changed

+14
-19
lines changed

1 file changed

+14
-19
lines changed

src/components/Breadcrumbs.tsx

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import { RestartButton } from '@/components/RestartButton';
1+
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';
22
import { isLocalStudio } from '@/config/constants';
3-
import { useInstanceClientIdParams } from '@/config/useInstanceClient';
43
import { Cluster, Instance, Organization } from '@/integrations/api/api.patch';
54
import { capitalizeWords } from '@/lib/string/capitalizeWords';
6-
import { Link, useLocation, useParams, useRouteContext } from '@tanstack/react-router';
5+
import { Link, useLocation, useRouteContext } from '@tanstack/react-router';
76
import { HomeIcon } from 'lucide-react';
87
import { useMemo } from 'react';
98

@@ -15,6 +14,7 @@ export function Breadcrumbs({ restartRequired }: { restartRequired?: boolean })
1514
instance?: Instance;
1615
cluster?: Cluster
1716
} = useRouteContext({ strict: false });
17+
const targetNoun = (instance || isLocalStudio) ? 'Instance' : 'Cluster';
1818

1919
const breadcrumbs = useMemo(() => {
2020
const routeHistory = location.pathname.split('/')
@@ -76,22 +76,17 @@ export function Breadcrumbs({ restartRequired }: { restartRequired?: boolean })
7676
return (
7777
<div role="list" className="flex items-center space-x-2 xl:space-x-4 sm:max-w-9/10 max-w-[calc(100%-56px)]">
7878
{...breadcrumbs}
79-
{restartRequired && <BreadcrumbsRestartButton />}
79+
{restartRequired && <Tooltip>
80+
<TooltipTrigger asChild>
81+
<div className="text-xs italic text-muted-foreground">
82+
* Restart <span className="hidden lg:inline-block">Requested</span>
83+
</div>
84+
</TooltipTrigger>
85+
<TooltipContent side="bottom">
86+
This {targetNoun} is requesting a restart, when convenient, to apply your latest changes.
87+
<br />You can do this from the Apps or Config pages.
88+
</TooltipContent>
89+
</Tooltip>}
8090
</div>
8191
);
8292
}
83-
84-
function BreadcrumbsRestartButton() {
85-
const { instanceId }: { instanceId?: string; clusterId: string; } = useParams({ strict: false });
86-
const targetNoun = (instanceId || isLocalStudio) ? 'Instance' : 'Cluster';
87-
const instanceParams = useInstanceClientIdParams();
88-
89-
return <RestartButton
90-
className="animate-glow-pulse"
91-
targetNoun={targetNoun}
92-
instanceClient={instanceParams.instanceClient}
93-
operation="restart"
94-
hideText={true}
95-
tooltip={`This ${targetNoun} is requesting a restart, when convenient, to apply your latest changes.`}
96-
/>;
97-
}

0 commit comments

Comments
 (0)