fix: Don’t abort database queries

It doesn’t help the server, and it ends up causing more duplicated queries at the moment. We can revisit this later if the need arises.

https://harperdb.atlassian.net/browse/STUDIO-508
https://harperdb.atlassian.net/browse/STUDIO-622

Author: dawsontoth

src/config/useInstanceClient.tsx

@@ -3,6 +3,7 @@ import { getInstanceClient } from '@/config/getInstanceClient';
 import { InstanceClientConfig, InstanceClientIdConfig, InstanceTypeConfig } from '@/config/instanceClientConfig';
 import { OverallAppSignIn } from '@/features/auth/store/authStore';
 import { useParams } from '@tanstack/react-router';
+import { useMemo } from 'react';
 
 export function useInstanceClient(operationsUrl?: string | null, port?: number, secure?: boolean) {
 	const { instanceId, clusterId }: { instanceId?: string; clusterId?: string } = useParams({ strict: false });
@@ -29,7 +30,12 @@ export function useInstanceClientIdParams(
 	secure?: boolean,
 ): InstanceClientIdConfig & InstanceTypeConfig {
 	const params: { instanceId?: string; clusterId?: string } = useParams({ strict: false });
-	return getInstanceClientIdFromParams({ ...params, operationsUrl, port, secure });
+	return useMemo(() => getInstanceClientIdFromParams({ ...params, operationsUrl, port, secure }), [
+		params,
+		operationsUrl,
+		port,
+		secure,
+	]);
 }
 
 export function getInstanceClientIdFromParams({

src/features/instance/databases/components/TableView.tsx

@@ -165,7 +165,7 @@ export function TableView<TData, TValue>({
 									setPageSize(Number(value));
 								}}
 							>
-								<SelectTrigger className="h-10 w-[80px]">
+								<SelectTrigger className="h-10 w-20">
 									<SelectValue />
 								</SelectTrigger>
 								<SelectContent side="top">

src/features/instance/databases/index.tsx

@@ -42,7 +42,7 @@ export function Databases() {
 	}
 
 	return (
-		<main className="grid grid-cols-1 gap-4 md:grid-cols-12 min-h-[calc(100vh-theme(spacing.36))]">
+		<main className="grid grid-cols-1 gap-4 md:grid-cols-12 min-h-[calc(100vh-(--spacing(36)))]">
 			<section className="col-span-1 text-white md:col-span-4 lg:col-span-3">
 				<DatabasesSidebar instanceDatabaseMap={instanceDatabaseMap} />
 			</section>

src/integrations/api/instance/database/getDescribeAll.ts

@@ -5,13 +5,14 @@ import { queryOptions } from '@tanstack/react-query';
 export function getDescribeAllQueryOptions({ entityId, instanceClient }: InstanceClientIdConfig) {
 	return queryOptions({
 		queryKey: [entityId, 'describe_all'] as const,
-		queryFn: async ({ signal }) => {
+		queryFn: async () => {
 			const { data } = await instanceClient.post<InstanceDatabaseMap>('/', {
 				operation: 'describe_all',
-			}, { signal });
+			});
 			return data;
 		},
-		staleTime: 60 * 1000,
+		staleTime: 60_000,
+		gcTime: 5_000,
 		retry: false,
 	});
 }

src/integrations/api/instance/database/getDescribeTable.ts

@@ -15,15 +15,16 @@ export function getDescribeTableQueryOptions({
 }: GetDescribeTableParams) {
 	return queryOptions({
 		queryKey: [entityId, databaseName, tableName, 'describe_table'] as const,
-		queryFn: async ({ signal }) => {
+		queryFn: async () => {
 			const { data } = await instanceClient.post<InstanceTable>('/', {
 				operation: 'describe_table',
 				database: databaseName,
 				table: tableName,
-			}, { signal });
+			});
 			return data;
 		},
-		staleTime: 60 * 1000,
+		staleTime: 60_000,
+		gcTime: 5_000,
 		enabled: !!databaseName && !!tableName,
 		retry: false,
 	});

src/integrations/api/instance/database/getSearchByConditions.ts

@@ -76,9 +76,10 @@ export function getSearchByConditionsOptions({
 			onlyIfCached,
 		] as const,
 		staleTime: 60_000,
+		gcTime: 5_000,
 
 		retry: false,
-		queryFn: ({ signal }) =>
+		queryFn: () =>
 			instanceClient.post<Record<string, unknown>[]>(
 				'/',
 				{
@@ -93,7 +94,7 @@ export function getSearchByConditionsOptions({
 					onlyIfCached: onlyIfCached,
 					noCacheStore: onlyIfCached,
 				} satisfies SearchByConditionsRequest,
-				{ timeout: 0, signal },
+				{ timeout: 0 },
 			),
 	});
 }

src/integrations/api/instance/database/getSearchById.ts

@@ -13,7 +13,7 @@ export function getSearchByIdOptions(
 ) {
 	return queryOptions({
 		queryKey: [entityId, 'search_by_id', databaseName, tableName, ids] as const,
-		queryFn: ({ signal }) =>
+		queryFn: () =>
 			instanceClient.post('/', {
 				get_attributes: ['*'],
 				ids,
@@ -22,7 +22,7 @@ export function getSearchByIdOptions(
 				operation: 'search_by_id',
 				database: databaseName,
 				table: tableName,
-			}, { signal }),
+			}),
 		enabled: enabled && !!ids?.length,
 		retry: false,
 	});

src/integrations/api/instance/database/getSearchByValue.ts

@@ -54,7 +54,8 @@ export function getSearchByValueOptions({
 		] as const,
 		retry: false,
 		staleTime: 60_000,
-		queryFn: ({ signal }) => {
+		gcTime: 5_000,
+		queryFn: () => {
 			const customizedSort = sort.attribute.length && !(sort.attribute === searchAttribute && !sort.descending);
 			return instanceClient.post<Record<string, unknown>[]>(
 				'/',
@@ -71,7 +72,7 @@ export function getSearchByValueOptions({
 					onlyIfCached: onlyIfCached,
 					noCacheStore: onlyIfCached,
 				} satisfies SearchByValueRequest,
-				{ timeout: 0, signal },
+				{ timeout: 0 },
 			);
 		},
 	});