Add Airy disk in SpotDiagram

[drpaprika]

Description

Add a plot_airy boolean option to analysis.SpotDiagram.view() to overlay the Airy disk on top of the spot diagram figure.
Add a plot_pixel boolean option to analysis.SpotDiagram.view() to overlay the pixel square on top of the spot diagram figure.
This allows the user for a quick visual assessment of the image quality when looking at the spot diagram.
Note that the Airy disk is not necessarily a circle, it can be oval if the focal lengths are not equal in X and Y directions.

Requirements

• Compute the Airy disk diameter as $r = 1.22 \cdot \lambda \cdot N$ in both directions, using a real ray trace (not paraxial quantities)
• Plot the airy disk as a dashed black line, centered on the (x,y) coordinates of the chief ray in the image plane
• Add a pixel_pitch optionnal argument to optic.Optic() to specify the pixel size in mm
• Plot the pixel as a dashed black line, centered on the (x,y) coordinates of the chief ray in the image plane
• Add documentation
• Add unit tests.

[HarrisonKramer]

Hi @drpaprika,

Thanks for opening this issue and clearly describing the addition and its requirements.

I recognize this as a solid addition to the package. If you or anyone is interested in contributing to this feature, please feel free to submit a pull request. I would welcome the contribution and can guide things along, if needed. I can also get to this myself eventually.

I'll keep the issue open for further discussions & updates.

Regards,
Kramer

[SeckinBerkay]

Didn't see the issue, while I was working on this issue. Sent pull request, may be enhanced with your suggestions. Didn't implement test case, unit tests may be added.

[HarrisonKramer]

Implemented in PR #51. Closing this issue.

I propose to move the pixel_pitch argument and pixel plotting into a separate issue.