chore: Removed some unncessary null checks from 'test.go' (microcks#131)

* chore: removed some unncessary null checks from 'test.go'

Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>

* chore: more clean up tasks

Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>

---------

Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>

Author: Harsh4902

cmd/importURL.go

@@ -47,7 +47,7 @@ func NewImportURLCommand() *cobra.Command {
 				os.Exit(1)
 			}
 
-			specificationFiles := os.Args[2]
+			specificationFiles := args[0]
 
 			// Collect optional HTTPS transport flags.
 			if insecureTLS {

cmd/test.go

@@ -28,8 +28,7 @@ import (
 )
 
 var (
-	runnerChoices   = map[string]bool{"HTTP": true, "SOAP_HTTP": true, "SOAP_UI": true, "POSTMAN": true, "OPEN_API_SCHEMA": true, "ASYNC_API_SCHEMA": true, "GRPC_PROTOBUF": true, "GRAPHQL_SCHEMA": true}
-	timeUnitChoices = map[string]bool{"milli": true, "sec": true, "min": true}
+	runnerChoices = map[string]bool{"HTTP": true, "SOAP_HTTP": true, "SOAP_UI": true, "POSTMAN": true, "OPEN_API_SCHEMA": true, "ASYNC_API_SCHEMA": true, "GRPC_PROTOBUF": true, "GRAPHQL_SCHEMA": true}
 )
 
 func NewTestCommand() *cobra.Command {
@@ -58,20 +57,20 @@ func NewTestCommand() *cobra.Command {
 				os.Exit(1)
 			}
 
-			serviceRef := os.Args[2]
-			testEndpoint := os.Args[3]
-			runnerType := os.Args[4]
+			serviceRef := args[0]
+			testEndpoint := args[1]
+			runnerType := args[2]
 
 			// Validate presence and values of args.
-			if &serviceRef == nil || strings.HasPrefix(serviceRef, "-") {
+			if len(serviceRef) == 0 || strings.HasPrefix(serviceRef, "-") {
 				fmt.Println("test command require <apiName:apiVersion> <testEndpoint> <runner> args")
 				os.Exit(1)
 			}
-			if &testEndpoint == nil || strings.HasPrefix(testEndpoint, "-") {
+			if len(testEndpoint) == 0 || strings.HasPrefix(testEndpoint, "-") {
 				fmt.Println("test command require <apiName:apiVersion> <testEndpoint> <runner> args")
 				os.Exit(1)
 			}
-			if &runnerType == nil || strings.HasPrefix(runnerType, "-") {
+			if len(runnerType) == 0 || strings.HasPrefix(runnerType, "-") {
 				fmt.Println("test command require <apiName:apiVersion> <testEndpoint> <runner> args")
 				os.Exit(1)
 			}
@@ -81,9 +80,8 @@ func NewTestCommand() *cobra.Command {
 			}
 
 			// Validate presence and values of flags.
-			if &waitFor == nil || (!strings.HasSuffix(waitFor, "milli") && !strings.HasSuffix(waitFor, "sec") && !strings.HasSuffix(waitFor, "min")) {
+			if !strings.HasSuffix(waitFor, "milli") && !strings.HasSuffix(waitFor, "sec") && !strings.HasSuffix(waitFor, "min") {
 				fmt.Println("--waitFor format is wrong. Applying default 5sec")
-				waitFor = "5sec"
 			}
 
 			// Collect optional HTTPS transport flags.

go.mod

@@ -2,4 +2,4 @@ module github.com/microcks/microcks-cli
 
 go 1.12
 
-require github.com/spf13/cobra v1.9.1 // indirect
+require github.com/spf13/cobra v1.9.1