Fix warnings on Windows. (ros2#2692)

For reasons I admit I do not understand, the deprecation
warnings for StaticSingleThreadedExecutor on Windows
happen when we construct a shared_ptr for it in the tests.
If we construct a regular object, then it is fine.  Luckily
this test does not require a shared_ptr, so just make it
a regular object here, which rixes the warning.

While we are in here, make all of the tests camel case to
be consistent.

Signed-off-by: Chris Lalancette <[email protected]>

Author: clalancette

rclcpp/test/rclcpp/executors/test_executors.cpp

@@ -881,18 +881,24 @@ TYPED_TEST(TestExecutors, testRaceDropCallbackGroupFromSecondThread)
   }
 
   // Create an executor
-  auto executor = std::make_shared<ExecutorType>();
-  executor->add_node(this->node);
+  ExecutorType executor;
+  executor.add_node(this->node);
 
   // Start spinning
   auto executor_thread = std::thread(
+<<<<<<< HEAD
     [executor]() {
       executor->spin();
 >>>>>>> e9b10042 (fix(Executor): Fix segfault if callback group is deleted during rmw_wait (#2683))
+=======
+    [&executor]() {
+      executor.spin();
+>>>>>>> 3310f9ea (Fix warnings on Windows. (#2692))
     });
 
   // As the problem is a race, we do this multiple times,
   // to raise our chances of hitting the problem
+<<<<<<< HEAD
 <<<<<<< HEAD
   for (size_t i = 0; i < 10; i++) {
     auto cg = this->node->create_callback_group(
@@ -901,6 +907,11 @@ TYPED_TEST(TestExecutors, testRaceDropCallbackGroupFromSecondThread)
   for(size_t i = 0; i < 10; i++) {
     auto cg = this->node->create_callback_group(rclcpp::CallbackGroupType::MutuallyExclusive);
 >>>>>>> e9b10042 (fix(Executor): Fix segfault if callback group is deleted during rmw_wait (#2683))
+=======
+  for (size_t i = 0; i < 10; i++) {
+    auto cg = this->node->create_callback_group(
+      rclcpp::CallbackGroupType::MutuallyExclusive);
+>>>>>>> 3310f9ea (Fix warnings on Windows. (#2692))
     auto timer = this->node->create_timer(1s, [] {}, cg);
     // sleep a bit, so that the spin thread can pick up the callback group
     // and add it to the executor
@@ -911,10 +922,14 @@ TYPED_TEST(TestExecutors, testRaceDropCallbackGroupFromSecondThread)
     // If the executor has a race, we will experience a segfault at this point.
   }
 
+<<<<<<< HEAD
 <<<<<<< HEAD
   executor.cancel();
 =======
   executor->cancel();
 >>>>>>> e9b10042 (fix(Executor): Fix segfault if callback group is deleted during rmw_wait (#2683))
+=======
+  executor.cancel();
+>>>>>>> 3310f9ea (Fix warnings on Windows. (#2692))
   executor_thread.join();
 }