Add file indexing on load and directory writable check in upload template

geek-at · geek-at · commit cc9b5d5d523a · 2025-12-11T16:24:46.000+01:00
diff --git a/web/lib/folderconfig.php b/web/lib/folderconfig.php
@@ -23,6 +23,30 @@ private function load()
             }
         } else {
             $this->config = $this->getDefaultConfig();
+            // Index existing files in the directory
+            $this->indexExistingFiles();
+            // Save the config with indexed files
+            $this->save();
+        }
+    }
+
+    private function indexExistingFiles()
+    {
+        $dir = ROOT.DS.'..'.DS.'data'.DS.$this->hostname;
+        if (is_dir($dir)) {
+            $files = scandir($dir);
+            foreach ($files as $file) {
+                if ($file === '.' || $file === '..' || $file === 'config.json') {
+                    continue;
+                }
+                $filepath = $dir.DS.$file;
+                if (is_file($filepath)) {
+                    $this->config['files'][$file] = [
+                        'uploaded' => filemtime($filepath),
+                        'size' => filesize($filepath)
+                    ];
+                }
+            }
         }
     }
 
@@ -116,4 +140,18 @@ public function getRetention()
     {
         return $this->config['retention'];
     }
+
+    public function isDirectoryWritable()
+    {
+        $dir = dirname($this->configPath);
+        if (!is_dir($dir)) {
+            return is_writable(dirname($dir));
+        }
+        return is_writable($dir);
+    }
+
+    public function getDirectoryPath()
+    {
+        return dirname($this->configPath);
+    }
 }
diff --git a/web/lib/upload-template.html.php b/web/lib/upload-template.html.php
@@ -36,10 +36,20 @@
         .files-list { margin-top: 20px; }
         .file-item { padding: 10px; background: #f8f9fa; border-radius: 4px; margin-bottom: 5px; display: flex; justify-content: space-between; align-items: center; }
         .file-info { font-family: monospace; font-size: 13px; }
+        .warning-box { background: #fff3cd; border-left: 4px solid #ffc107; color: #856404; padding: 15px; margin-bottom: 20px; border-radius: 4px; }
+        .warning-box strong { display: block; margin-bottom: 5px; }
     </style>
 </head> 
 <body>
     <div class="container">
+        <?php if(!$config->isDirectoryWritable()): ?>
+        <div class="warning-box">
+            <strong>⚠️ Warning: Directory Not Writable</strong>
+            <p>The backup directory <code><?=htmlspecialchars($config->getDirectoryPath())?></code> is not writable. Backups cannot be saved until this is fixed.</p>
+            <p>Please check your file permissions and ensure the web server has write access to this directory.</p>
+        </div>
+        <?php endif; ?>
+        
         <div class="card">
             <h1>Backup: <?=htmlspecialchars($hostname)?></h1>
             <form action="/<?=htmlspecialchars($url[0])?>" class="dropzone" id="backup-dropzone" method="POST" enctype="multipart/form-data"></form>
