Skip to content

Commit 4668f62

Browse files
committed
Remove mongodb port mapping
Test suite no longer needs a “real” mongodb instance
1 parent fde9cfc commit 4668f62

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

Changes.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,5 @@
88
- Swap default Docker environment from production to development, to improve DX.
99
- Eliminate production-mode inclusion of devDependencies, to keep production Docker image as light as possible and lower production-mode memory usage.
1010
- Explicitly volume-map all files into Docker container when in dev-mode.
11-
- Restore mongodb port mapping, for test suite (temporary - this should be removed once the test suite properly uses an in-memory mock db).
1211
- Removed the --harmony-proxies flag from npm test, as it is no longer supported by nodejs.
1312
- Eliminate different markup warning between client/server during dev

docker-compose-production.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ services:
1414
MONGO_URL: mongodb://db:27017/mern-starter
1515
db:
1616
image: mongo:latest
17-
ports:
18-
- "27017:27017"
1917
volumes:
2018
- dbdata:/data/db
2119
volumes:

docker-compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ services:
2929
tty: true
3030
db:
3131
image: mongo:latest
32-
ports:
33-
- "27017:27017"
3432
volumes:
3533
- dbdata:/data/db
3634
volumes:

0 commit comments

Comments
 (0)