feat: get best block height from features API (#541)

* feat: get best block height from features API

Author: r4mmer

__tests__/__fixtures__/http-fixtures.js

@@ -1120,6 +1120,11 @@ export default {
     success: true,
     blocks: 1242,
   },
+  '/feature': {
+    block_hash: '00000008707722cde59ac9e7f4d44efbd3a5bd5f244223816ee676d328943b1b',
+    block_height: 1242,
+    features: [],
+  },
   '/nano_contract/state': {
     success: true,
     nc_id: '3cb032600bdf7db784800e4ea911b10676fa2f67591f82bb62628c234e771595',

__tests__/test-utils.js

@@ -218,6 +218,7 @@ class TestUtils {
       return [200, httpFixtures['/transaction']];
     });
     httpMock.onGet('/getmininginfo').reply(200, httpFixtures['/getmininginfo']);
+    httpMock.onGet('/feature').reply(200, httpFixtures['/feature']);
     httpMock.onGet('http://fake.txmining:8084/health').reply(200, httpFixtures['http://fake.txmining:8084/health']);
     httpMock.onGet('/nano_contract/state').reply(200, httpFixtures['/nano_contract/state']);
     httpMock.onGet('/nano_contract/history').reply(200, httpFixtures['/nano_contract/history']);

package-lock.json

@@ -10,7 +10,7 @@
   "dependencies": {
     "@dinamonetworks/hsm-dinamo": "4.9.1",
     "@hathor/healthcheck-lib": "0.1.0",
-    "@hathor/wallet-lib": "2.1.1",
+    "@hathor/wallet-lib": "2.3.0",
     "axios": "1.7.7",
     "express": "4.18.2",
     "express-validator": "6.10.0",

package.json

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-const { txApi, walletApi, WalletType, constants: hathorLibConstants, helpersUtils, errors, tokensUtils, transactionUtils, PartialTx } = require('@hathor/wallet-lib');
+const { txApi, featuresApi, WalletType, constants: hathorLibConstants, helpersUtils, errors, tokensUtils, transactionUtils, PartialTx } = require('@hathor/wallet-lib');
 const { matchedData } = require('express-validator');
 // import is used because there is an issue with winston logger when using require ref: #262
 const { JSONBigInt } = require('@hathor/wallet-lib/lib/utils/bigint');
@@ -226,7 +226,6 @@ async function getTxConfirmationBlocks(req, res) {
   // Disabling this eslint rule because of the way API call is done in the lib
   // otherwise the code would need to be more complex
   // We should change this when we refactor the way we call APIs in the lib
-  // (this comment also applies for the getMiningInfo call)
   // eslint-disable-next-line no-promise-executor-return
   const txDataResponse = await new Promise(resolve => txApi.getTransaction(id, resolve));
 
@@ -236,10 +235,11 @@ async function getTxConfirmationBlocks(req, res) {
   }
 
   // Now we get the current height of the network
-  // eslint-disable-next-line no-promise-executor-return
-  const networkHeightResponse = await new Promise(resolve => walletApi.getMiningInfo(resolve));
-
-  if (!networkHeightResponse.success) {
+  let bestChainHeight;
+  try {
+    const featuresResponse = await featuresApi.getFeatures();
+    bestChainHeight = featuresResponse.block_height;
+  } catch (err) {
     res.send({ success: false, error: 'Failed to get network heigth from the full node.' });
     return;
   }
@@ -248,7 +248,7 @@ async function getTxConfirmationBlocks(req, res) {
 
   // first_block_height will be null until a block confirms this transaction
   if (txDataResponse.meta && txDataResponse.meta.first_block_height) {
-    confirmationNumber = networkHeightResponse.blocks - txDataResponse.meta.first_block_height;
+    confirmationNumber = bestChainHeight - txDataResponse.meta.first_block_height;
   }
 
   res.send({ success: true, confirmationNumber });