-
Notifications
You must be signed in to change notification settings - Fork 1
Description
After removing the lambdas that used to deal with new transactions and with voiding transactions, I noticed that we are missing some tests in the new service, here is the list:
-
start wallet and then receive blocks and txs -
receive blocks, start wallet and then receive transactions -
receive blocks and tx1, start wallet and then receive tx2 -
receive blocks fom 3 different miners, check miners list
For the tests above, we need to somehow create integration tests that use both packages, the wallet-service lambdas and the daemon.
-
txProcessor should ignore NFT outputs
We are still ignoring NFT outputs, but have no tests for this case, we should add it
-
receive token creation tx
We are storing tokens in the database in the new daemon, but we're not testing it.
-
txProcessor should rollback the entire transaction if an error occurs on balance calculation
We are still rolling back when we fail to process a message, but now on different methods — handleVoidedTx, handleVertexAccepted, handleUnvoidedTx
We should re-create this test for all of them
-
txProcess onNewTxRequest with push notification
The daemon now simply calls the push notification lambda, but we don't have tests for it, we should add it
-
onNewTxRequest should send alert on SQS on failure
We are dealing with events differently now, but we're not sending an alert with rich metadata when the daemon stops. We should refactor the daemon to add an alert directly to SQS (instead of just logging the error) and add a test for it.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status