added LocalVariableNameCheck

Author: AlexHaxe

README.md

@@ -131,6 +131,13 @@ More information in [wiki page](https://github.com/adireddy/haxe-checkstyle/wiki
 				]
 			}
 		},
+		{
+			"type": "LocalVariableName",
+			"props": {
+				"severity": "ERROR",
+				"format": "^[a-z]+[a-zA-Z0-9]*$"
+			}
+		},
 		{
 			"type": "MemberName",
 			"props": {

checkstyle/checks/Check.hx

@@ -75,6 +75,10 @@ class Check {
 		return isCharPosSuppressed(pos);
 	}
 
+	function isPosExtern(pos:Position):Bool {
+		return isCharPosExtern(pos.min);
+	}
+
 	function isPosSuppressed(pos:Position):Bool {
 		return isCharPosSuppressed(pos.min);
 	}
@@ -131,6 +135,37 @@ class Check {
 		return false;
 	}
 
+	function isCharPosExtern(pos:Int):Bool {
+		for (td in checker.ast.decls) {
+			switch (td.decl){
+				case EAbstract(d):
+				case EClass(d):
+					if ((pos <= td.pos.max) && (pos >= td.pos.min)) {
+						return d.flags.indexOf(HExtern) > -1;
+					}
+				case EEnum(d):
+					if ((pos <= td.pos.max) && (pos >= td.pos.min)) {
+						return d.flags.indexOf(EExtern) > -1;
+					}
+				case ETypedef(d):
+					if ((pos <= td.pos.max) && (pos >= td.pos.min)) {
+						return d.flags.indexOf(EExtern) > -1;
+					}
+					switch (d.data) {
+						case TAnonymous(fields):
+							for (field in fields) {
+								if (pos > field.pos.max) continue;
+								if (pos < field.pos.min) continue;
+								return d.flags.indexOf(EExtern) > -1;
+							}
+						default:
+					}
+				default:
+			}
+		}
+		return false;
+	}
+
 	function checkSuppressionConst(e:Expr, search:String):Bool {
 		switch (e.expr) {
 			case EArrayDecl(a):

checkstyle/checks/LocalVariableNameCheck.hx

@@ -0,0 +1,30 @@
+package checkstyle.checks;
+
+import checkstyle.LintMessage.SeverityLevel;
+import haxeparser.Data;
+import haxe.macro.Expr;
+
+@name("LocalVariableName")
+@desc("Checks on naming conventions of local variables")
+class LocalVariableNameCheck extends NameCheckBase {
+
+	public function new() {
+		super();
+		format = "^[a-z]+[a-zA-Z0-9]*$";
+	}
+
+	override function actualRun() {
+		formatRE = new EReg (format, "");
+		ExprUtils.walkFile(checker.ast, function(e) {
+			switch(e.expr) {
+				case EVars(vars):
+					if (ignoreExtern && isPosExtern(e.pos)) return;
+					if (isPosSuppressed(e.pos)) return;
+					for (v in vars) {
+						matchTypeName("local var", v.name, e.pos);
+					}
+				default:
+			}
+		});
+	}
+}

resources/config.json

@@ -108,6 +108,13 @@
 				]
 			}
 		},
+		{
+			"type": "LocalVariableName",
+			"props": {
+				"severity": "ERROR",
+				"format": "^[a-z]+[a-zA-Z0-9]*$"
+			}
+		},
 		{
 			"type": "MemberName",
 			"props": {

test/LocalVariableNameCheckTest.hx

@@ -0,0 +1,94 @@
+package ;
+
+import checkstyle.checks.LocalVariableNameCheck;
+
+class LocalVariableNameCheckTest extends CheckTestCase {
+
+	public function testCorrectNaming() {
+		var check = new LocalVariableNameCheck ();
+		assertMsg(check, LocalVariableNameTests.TEST, '');
+		assertMsg(check, LocalVariableNameTests.TEST4, '');
+	}
+
+	public function testWrongNaming() {
+		var check = new LocalVariableNameCheck ();
+		assertMsg(check, LocalVariableNameTests.TEST1, 'Invalid local var signature: Count (name should be ~/^[a-z]+[a-zA-Z0-9]*$/)');
+		assertMsg(check, LocalVariableNameTests.TEST3, 'Invalid local var signature: Count (name should be ~/^[a-z]+[a-zA-Z0-9]*$/)');
+	}
+
+	public function testIgnoreExtern() {
+		var check = new LocalVariableNameCheck ();
+		check.ignoreExtern = false;
+
+		assertMsg(check, LocalVariableNameTests.TEST, '');
+		assertMsg(check, LocalVariableNameTests.TEST1, 'Invalid local var signature: Count (name should be ~/^[a-z]+[a-zA-Z0-9]*$/)');
+		assertMsg(check, LocalVariableNameTests.TEST3, 'Invalid local var signature: Count (name should be ~/^[a-z]+[a-zA-Z0-9]*$/)');
+		assertMsg(check, LocalVariableNameTests.TEST4, 'Invalid local var signature: Count (name should be ~/^[a-z]+[a-zA-Z0-9]*$/)');
+	}
+
+	public function testFormat() {
+		var check = new LocalVariableNameCheck ();
+		check.format = "^[A-Za-z_]*$";
+
+		assertMsg(check, LocalVariableNameTests.TEST, 'Invalid local var signature: count2 (name should be ~/^[A-Za-z_]*$/)');
+		assertMsg(check, LocalVariableNameTests.TEST1, '');
+		assertMsg(check, LocalVariableNameTests.TEST3, '');
+		assertMsg(check, LocalVariableNameTests.TEST4, '');
+	}
+}
+
+class LocalVariableNameTests {
+	public static inline var TEST:String = "
+	class Test {
+		public function test() {
+			var a:Int;
+			var b:Int;
+		}
+		@SuppressWarnings('checkstyle:LocalVariableName')
+		public function test() {
+			var I:Int;
+		}
+	}
+
+	enum Test2 {
+		count;
+		a;
+	}
+
+	typedef Test3 = {
+		public function test() {
+			var count1:Int;
+			var count2:String;
+		};
+		@SuppressWarnings('checkstyle:LocalVariableName')
+		var COUNT6:Int = 1;
+	}
+
+	typedef Test4 = {
+		@SuppressWarnings('checkstyle:LocalVariableName')
+		public function test() {
+			var Count1:Int;
+		};
+	}";
+
+	public static inline var TEST1:String = "
+	class Test {
+		public function test() {
+			var Count:Int = 1;
+		}
+	}";
+
+	public static inline var TEST3:String =
+	"typedef Test = {
+		public function test() {
+			var Count:Int;
+		}
+	}";
+
+	public static inline var TEST4:String =
+	"extern class Test {
+		public function test() {
+			var Count:Int = 1;
+		}
+	}";
+}

test/TestMain.hx

@@ -11,11 +11,12 @@ class TestMain {
 		runner.add(new DynamicCheckTest());
 		runner.add(new EmptyLinesCheckTest());
 		runner.add(new ERegInstantiationCheckTest());
+		runner.add(new FileLengthCheckTest());
 		runner.add(new HexadecimalLiteralsCheckTest());
 		runner.add(new IndentationCharacterCheckTest());
 		runner.add(new LineLengthCheckTest());
 		runner.add(new ListenerNameCheckTest());
-		runner.add(new FileLengthCheckTest());
+		runner.add(new LocalVariableNameCheckTest());
 		runner.add(new MemberNameCheckTest());
 		runner.add(new MethodLengthCheckTest());
 		runner.add(new MethodNameCheckTest());