refactored reporting

Author: adireddy

CHECKS.md

@@ -9,6 +9,7 @@
 --each
 
 -main checkstyle.Main
+-D checkstyle
 -neko run.n
 
 --next

build.hxml

@@ -30,7 +30,7 @@ class Main {
 			var main = new Main();
 			main.run(args);
 
-			if (REPORT) {
+			if (REPORT && REPORT_TYPE == "xml") {
 				var reporter = new Report();
 				reporter.generateReport(PATH);
 			}
@@ -47,7 +47,7 @@ class Main {
 	var checker:Checker;
 
 	static var REPORT:Bool = false;
-	static var REPORT_TYPE:String = "default";
+	static var REPORT_TYPE:String = "xml";
 	static var PATH:String = "check-style-report.xml";
 	static var STYLE:String = "";
 
@@ -66,7 +66,6 @@ class Main {
 		@doc("Set reporter path") ["-p", "--path"] => function(loc:String) PATH = loc,
 		@doc("Set reporter style (XSLT)") ["-x", "--xslt"] => function(x:String) STYLE = x,
 		@doc("Set reporter") ["-r", "--reporter"] => function(reporterName:String) REPORT_TYPE = reporterName,
-		@doc("List all reporters") ["--list-reporters"] => function() listReporters(),
 		@doc("Set config file") ["-c", "--config"] => function(cpath:String) configPath = cpath,
 		@doc("List all checks") ["--list-checks"] => function() listChecks(),
 		@doc("Generate build time report") ["-report"] => function() REPORT = true,
@@ -117,12 +116,6 @@ class Main {
 		for (check in info.checks()) Sys.println('${check.name}: ${check.description}');
 	}
 
-	static function listReporters() {
-		Sys.println("default - Default reporter");
-		Sys.println("xml - Checkstyle-like XML reporter");
-		Sys.exit(0);
-	}
-
 	static function createReporter():IReporter {
 		return switch(REPORT_TYPE) {
 			case "xml": new XMLReporter(PATH, STYLE);

checkstyle/Main.hx

@@ -1,7 +1,9 @@
 package checkstyle;
 
+#if checkstyle
 import sys.io.FileOutput;
 import sys.io.File;
+#end
 
 class Report {
 
@@ -13,8 +15,12 @@ class Report {
 	@SuppressWarnings('checkstyle:LineLength')
 	public function generateReport(path:String) {
 		staticAnalysisXML = Xml.parse(File.getContent(path));
+
+		#if checkstyle
 		reportFile = File.write("CHECKS.md", false);
 		reportFile.writeString("###Report of default checks on CheckStyle library itself\n\n");
+		#end
+		
 		var errors = 0;
 		var warnings = 0;
 		var infos = 0;
@@ -30,22 +36,21 @@ class Report {
 					case "error":
 						errors++;
 						Sys.println("\t\033[91mError: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "\033[0m");
-						reportFile.writeString("`Error: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "`\n\n");
+						#if checkstyle reportFile.writeString("`Error: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "`\n\n"); #end
 					case "warning":
 						warnings++;
 						Sys.println("\t\033[95mWarning: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "\033[0m");
-						reportFile.writeString("`Warning: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "`\n\n");
+						#if checkstyle reportFile.writeString("`Warning: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "`\n\n"); #end
 					case "info":
 						infos++;
 						Sys.println("\t\033[94mInfo: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "\033[0m");
-						reportFile.writeString("`Info: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "`\n\n");
+						#if checkstyle reportFile.writeString("`Info: LINE - " + errorNode.get("line") + ": " + StringTools.htmlUnescape(errorNode.get("message")) + "`\n\n"); #end
 				}
 				total++;
 			}
 		}
 
 		Sys.println("\033[1m\nTotal Issues: " + total + " (\033[0m\033[91mErrors: " + errors + "\033[0m, \033[95mWarnings: " + warnings + "\033[0m, \033[94mInfos: " + infos + ")\n" + "\033[0m");
-
-		reportFile.writeString("`Total Issues: " + total + " (Errors: " + errors + " Warnings: " + warnings + " Infos: " + infos + ")`");
+		#if checkstyle reportFile.writeString("`Total Issues: " + total + " (Errors: " + errors + " Warnings: " + warnings + " Infos: " + infos + ")`"); #end
 	}
 }