Skip to content

Commit 8eb0d1d

Browse files
committed
added ignoreOverriddenMethods to ParameterNumberCheck
1 parent 6368c49 commit 8eb0d1d

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ More information in [wiki page](https://github.com/adireddy/haxe-checkstyle/wiki
112112
"type": "ParameterNumber",
113113
"props": {
114114
"severity": "INFO",
115-
"max": 10
115+
"max": 10,
116+
"ignoreOverriddenMethods": false
116117
}
117118
},
118119
{

checkstyle/checks/ParameterNumberCheck.hx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ class ParameterNumberCheck extends Check {
1010

1111
public var severity:String = "INFO";
1212
public var max:Int = 10;
13+
public var ignoreOverriddenMethods:Bool = false;
1314

1415
override function _actualRun() {
1516
for (td in _checker.ast.decls) {
@@ -28,6 +29,7 @@ class ParameterNumberCheck extends Check {
2829
}
2930

3031
function checkField(f:Field) {
32+
if (ignoreOverriddenMethods && f.access.indexOf(AOverride) >= 0) return;
3133
switch (f.kind) {
3234
case FFun(fun):
3335
if ((fun.args != null) && (fun.args.length > max)) {

resources/config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@
9595
"type": "ParameterNumber",
9696
"props": {
9797
"severity": "INFO",
98-
"max": 10
98+
"max": 10,
99+
"ignoreOverriddenMethods": false
99100
}
100101
},
101102
{

run.n

104 Bytes
Binary file not shown.

test/ParameterNumberCheckTest.hx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@ class ParameterNumberCheckTest extends CheckTestCase {
3838
var msg = checkMessage(ParameterNumberTests.TEST5, new ParameterNumberCheck());
3939
assertEquals('Too many parameters for function: test4 (> 10)', msg);
4040
}
41+
42+
public function testIgnoreOverridenMethods() {
43+
var check = new ParameterNumberCheck();
44+
check.ignoreOverriddenMethods = true;
45+
46+
var msg = checkMessage(ParameterNumberTests.TEST3, check);
47+
assertEquals('', msg);
48+
}
4149
}
4250

4351
class ParameterNumberTests {
@@ -65,7 +73,7 @@ class ParameterNumberTests {
6573

6674
public static inline var TEST3:String =
6775
"class Test {
68-
public function test2(param1:Int,
76+
override public function test2(param1:Int,
6977
param2:Int,
7078
param3:Int,
7179
param4:Int,

0 commit comments

Comments
 (0)