Skip to content

Commit 961c6d0

Browse files
committed
more unit tests
1 parent dd25faa commit 961c6d0

File tree

3 files changed

+71
-16
lines changed

3 files changed

+71
-16
lines changed

test/CheckTestCase.hx

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,24 @@ class CheckTestCase extends haxe.unit.TestCase {
99

1010
static inline var FILE_NAME = "Test.hx";
1111

12-
function messageEquals(expected:LintMessage, actual:LintMessage) {
13-
assertEquals(expected.fileName, actual.fileName);
14-
assertEquals(expected.moduleName, actual.moduleName);
15-
assertEquals(expected.line, actual.line);
16-
assertEquals(expected.column, actual.column);
17-
assertEquals(expected.severity, actual.severity);
18-
assertEquals(expected.message, actual.message);
12+
var _checker:Checker;
13+
var _reporter:TestReporter;
14+
15+
override public function setup() {
16+
_checker = new Checker();
17+
_reporter = new TestReporter();
1918
}
2019

2120
function checkMessage(src, check):String {
22-
var checker = new Checker();
23-
var rep = new TestReporter();
24-
checker.addCheck(check);
25-
checker.addReporter(rep);
26-
checker.process([{name:FILE_NAME, content:src}]);
27-
return rep.message;
21+
_checker.addCheck(check);
22+
_checker.addReporter(_reporter);
23+
_checker.process([{name:FILE_NAME, content:src}]);
24+
return _reporter.message;
25+
}
26+
27+
override public function tearDown() {
28+
_checker = null;
29+
_reporter = null;
2830
}
2931
}
3032

@@ -37,11 +39,8 @@ class TestReporter implements IReporter {
3739
}
3840

3941
public function start() {}
40-
4142
public function finish() {}
42-
4343
public function fileStart(f:LintFile) {}
44-
4544
public function fileFinish(f:LintFile) {}
4645

4746
public function addMessage(m:LintMessage) {

test/LineLengthCheckTest.hx

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
package ;
2+
3+
import checkstyle.checks.LineLengthCheck;
4+
5+
class LineLengthCheckTest extends CheckTestCase {
6+
7+
public function testDefaultLineLength(){
8+
var msg = checkMessage(LineLengthTests.TEST1, new LineLengthCheck());
9+
assertEquals(msg, 'Too long line (> 80)');
10+
}
11+
12+
public function testCorrectLineLength(){
13+
var msg = checkMessage(LineLengthTests.TEST2, new LineLengthCheck());
14+
assertEquals(msg, '');
15+
}
16+
17+
public function testConfigurableLineLength(){
18+
var check = new LineLengthCheck();
19+
check.maxCharacters = 40;
20+
21+
var msg = checkMessage(LineLengthTests.TEST3, check);
22+
assertEquals(msg, 'Too long line (> 40)');
23+
}
24+
}
25+
26+
class LineLengthTests {
27+
public static inline var TEST1:String = "
28+
class Test {
29+
var _a:Int;
30+
public function new() {
31+
_a = 10;
32+
if (_a > 200 && _a < 250 && _a != 240 && _a != 250 && _a != 260 && _a != 270 && _a != 280 && _a != 290) {
33+
_a = -1;
34+
}
35+
}
36+
}";
37+
38+
public static inline var TEST2:String =
39+
"class Test {
40+
public function new() {
41+
var b:Int;
42+
}
43+
}";
44+
45+
public static inline var TEST3:String =
46+
"class Test {
47+
public function new() {
48+
_a = 10;
49+
if (_a > 200 && _a < 250 && _a != 240 && _a != 250) {
50+
_a = -1;
51+
}
52+
}
53+
}";
54+
}

test/TestMain.hx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ class TestMain {
99
runner.add(new BlockFormatCheckTest());
1010
runner.add(new EmptyLinesCheckTest());
1111

12+
runner.add(new LineLengthCheckTest());
13+
1214
runner.add(new ListenerNameCheckTest());
1315

1416
var success = runner.run();

0 commit comments

Comments
 (0)