added type check

Author: adireddy

checkstyle/checks/NamingCheck.hx

@@ -104,7 +104,7 @@ class NamingCheck extends Check {
 
 	function checkLocalVars() {
 		ExprUtils.walkFile(_checker.ast, function(e) {
-			switch(e.expr){
+			switch(e.expr) {
 				case EVars(vars):
 					for (v in vars) {
 						if (!localCamelCaseRE.match(v.name)) logPos('Invalid local variable signature: ${v.name} (name should be camelCase)', e.pos, Reflect.field(SeverityLevel, severity));

checkstyle/checks/TypeCheck.hx

@@ -0,0 +1,39 @@
+package checkstyle.checks;
+
+import checkstyle.LintMessage.SeverityLevel;
+import haxeparser.Data;
+import haxe.macro.Expr;
+
+@name("Type")
+@desc("Type check for class variables")
+class TypeCheck extends Check {
+
+	public var severity:String = "ERROR";
+
+	override function _actualRun() {
+		checkClassFields();
+	}
+
+	function checkClassFields() {
+		for (td in _checker.ast.decls) {
+			switch (td.decl){
+				case EClass(d):
+					for (field in d.data) if (field.name != "new") checkField(field);
+				default:
+			}
+		}
+	}
+
+	function checkField(f:Field) {
+		switch(f.kind) {
+			case FVar(t, e):
+				if (t == null) _error(f.name, f.pos);
+			case FProp(g, s, t, e):
+			case FFun(f):
+		}
+	}
+
+	function _error(name:String, pos:Position) {
+		logPos('Missing type: ${name}', pos, Reflect.field(SeverityLevel, severity));
+	}
+}

haxelib.json

@@ -10,8 +10,8 @@
 	],
 	"description": "Automated code analysis ideal for projects that want to enforce a coding standard.",
 	"contributors": ["adireddy"],
-	"releasenote": "improved naming check",
-	"version": "1.0.3",
+	"releasenote": "added type check",
+	"version": "1.0.4",
 	"url": "https://github.com/adireddy/haxe-checkstyle",
 	"dependencies": {
 

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "checkstyle",
-	"version": "1.0.3",
+	"version": "1.0.4",
 	"description": "Automated code analysis ideal for projects that want to enforce a coding standard.",
 	"repository": {
 		"type": "git",

resources/config.json

@@ -117,6 +117,12 @@
 				"severity": "INFO"
 			}
 		},
+		{
+			"type": "Type",
+			"props": {
+				"severity": "ERROR"
+			}
+		},
 		{
 			"type": "VariableInitialisation",
 			"props": {

run.n

@@ -22,6 +22,7 @@ class TestMain {
 		runner.add(new TabForAligningCheckTest());
 		runner.add(new TODOCommentCheckTest());
 		runner.add(new TrailingWhitespaceCheckTest());
+		runner.add(new TypeCheckTest());
 		runner.add(new VariableInitialisationCheckTest());
 
 		var success = runner.run();

test/TestMain.hx

@@ -0,0 +1,28 @@
+package ;
+
+import checkstyle.checks.TypeCheck;
+
+class TypeCheckTest extends CheckTestCase {
+
+	public function testClassVar() {
+		var msg = checkMessage(TypeTests.TEST1, new TypeCheck());
+		assertEquals(msg, 'Missing type: _a');
+	}
+
+	public function testStaticClassVar() {
+		var msg = checkMessage(TypeTests.TEST2, new TypeCheck());
+		assertEquals(msg, 'Missing type: A');
+	}
+}
+
+class TypeTests {
+	public static inline var TEST1:String = "
+	class Test {
+		var _a;
+	}";
+
+	public static inline var TEST2:String = "
+	class Test {
+		static inline var A = 1;
+	}";
+}