Skip to content

Commit c723c35

Browse files
committed
added method length check
1 parent 2367eec commit c723c35

File tree

2 files changed

+114
-3
lines changed

2 files changed

+114
-3
lines changed

test/LineLengthCheckTest.hx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@ import checkstyle.checks.LineLengthCheck;
44

55
class LineLengthCheckTest extends CheckTestCase {
66

7-
public function testDefaultLineLength(){
7+
public function testDefaultLineLength() {
88
var msg = checkMessage(LineLengthTests.TEST1, new LineLengthCheck());
99
assertEquals(msg, 'Too long line (> 80)');
1010
}
1111

12-
public function testCorrectLineLength(){
12+
public function testCorrectLineLength() {
1313
var msg = checkMessage(LineLengthTests.TEST2, new LineLengthCheck());
1414
assertEquals(msg, '');
1515
}
1616

17-
public function testConfigurableLineLength(){
17+
public function testConfigurableLineLength() {
1818
var check = new LineLengthCheck();
1919
check.maxCharacters = 40;
2020

test/MethodLengthCheckTest.hx

Lines changed: 111 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
1+
package ;
2+
3+
import checkstyle.checks.MethodLengthCheck;
4+
5+
class MethodLengthCheckTest extends CheckTestCase {
6+
7+
public function testWrongMethodLength() {
8+
var msg = checkMessage(MethodLengthTests.TEST1, new MethodLengthCheck());
9+
assertEquals(msg, 'Function is too long: test (> 50 lines, try splitting into multiple functions)');
10+
}
11+
12+
public function testCorrectMethodLength() {
13+
var msg = checkMessage(MethodLengthTests.TEST2, new MethodLengthCheck());
14+
assertEquals(msg, '');
15+
}
16+
17+
public function testConfigurableMethodLength() {
18+
var check = new MethodLengthCheck();
19+
check.maxFunctionLines = 10;
20+
21+
var msg = checkMessage(MethodLengthTests.TEST3, check);
22+
assertEquals(msg, 'Function is too long: test (> 10 lines, try splitting into multiple functions)');
23+
}
24+
}
25+
26+
class MethodLengthTests {
27+
public static inline var TEST1:String = "
28+
class Test {
29+
public function test() {
30+
tarce('TEST');
31+
32+
tarce('TEST');
33+
34+
tarce('TEST');
35+
36+
tarce('TEST');
37+
38+
tarce('TEST');
39+
40+
tarce('TEST');
41+
42+
tarce('TEST');
43+
44+
tarce('TEST');
45+
46+
tarce('TEST');
47+
48+
tarce('TEST');
49+
50+
tarce('TEST');
51+
52+
tarce('TEST');
53+
54+
tarce('TEST');
55+
56+
tarce('TEST');
57+
58+
tarce('TEST');
59+
60+
tarce('TEST');
61+
62+
tarce('TEST');
63+
64+
tarce('TEST');
65+
66+
tarce('TEST');
67+
68+
tarce('TEST');
69+
70+
tarce('TEST');
71+
72+
tarce('TEST');
73+
74+
tarce('TEST');
75+
76+
tarce('TEST');
77+
78+
tarce('TEST');
79+
80+
tarce('TEST');
81+
}
82+
}";
83+
84+
public static inline var TEST2:String =
85+
"class Test {
86+
public function test() {
87+
tarce('TEST');
88+
89+
tarce('TEST');
90+
91+
tarce('TEST');
92+
}
93+
}";
94+
95+
public static inline var TEST3:String =
96+
"class Test {
97+
public function test() {
98+
tarce('TEST');
99+
100+
tarce('TEST');
101+
102+
tarce('TEST');
103+
104+
tarce('TEST');
105+
106+
tarce('TEST');
107+
108+
tarce('TEST');
109+
}
110+
}";
111+
}

0 commit comments

Comments
 (0)