Skip to content

Commit c8a4ac8

Browse files
AlexHaxeAlexHaxe
authored
new checks RedundantAccessMeta + RedundantAllowMeta, fixes #193 (#445)
* new checks RedundantAccessMeta + RedundantAllowMeta, fixes #193
1 parent b49d9c3 commit c8a4ac8

14 files changed

+452
-49
lines changed

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
- New check DocCommentStyle [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
44
- New check FieldDocComment, fixes [#87](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/87) ([#442](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/442) + [#444](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/444))
55
- New check TypeDocComment [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
6+
- New check RedundantAccessMeta, fixes [#193](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/193) ([#445](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/445))
7+
- New check RedundantAllowMeta, fixes [#193](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/193) ([#445](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/445))
68
- Added relaxed mode to ConfigParser, fixes [#441](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/441) ([#443](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/443))
79
- Fixed handling of comments between types in ExtendedEmptyLines [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
810
- Fixed unittest and coverage reporting for Haxe 4 [#442](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/442)

‎checkstyle.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,12 @@
372372
{
373373
"type": "RedundantModifier"
374374
},
375+
{
376+
"type": "RedundantAllowMeta"
377+
},
378+
{
379+
"type": "RedundantAccessMeta"
380+
},
375381
{
376382
"props": {
377383
"allowEmptyReturn": true,

‎resources/checkstyle-excludes-schema.json‎

Lines changed: 31 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"description": "defines filters to exclude folders, types or files from all or specific checks",
1616
"properties": {
1717
"RightCurly": {
18-
"propertyOrder": 54,
18+
"propertyOrder": 56,
1919
"$ref": "#/definitions/ExcludeFilterList"
2020
},
2121
"path": {
@@ -32,7 +32,7 @@
3232
"$ref": "#/definitions/ExcludeFilterList"
3333
},
3434
"VariableInitialisation": {
35-
"propertyOrder": 71,
35+
"propertyOrder": 73,
3636
"$ref": "#/definitions/ExcludeFilterList"
3737
},
3838
"HexadecimalLiteral": {
@@ -52,7 +52,7 @@
5252
"$ref": "#/definitions/ExcludeFilterList"
5353
},
5454
"RedundantModifier": {
55-
"propertyOrder": 51,
55+
"propertyOrder": 53,
5656
"$ref": "#/definitions/ExcludeFilterList"
5757
},
5858
"PublicAccessor": {
@@ -76,11 +76,11 @@
7676
"$ref": "#/definitions/ExcludeFilterList"
7777
},
7878
"Spacing": {
79-
"propertyOrder": 59,
79+
"propertyOrder": 61,
8080
"$ref": "#/definitions/ExcludeFilterList"
8181
},
8282
"UnusedImport": {
83-
"propertyOrder": 69,
83+
"propertyOrder": 71,
8484
"$ref": "#/definitions/ExcludeFilterList"
8585
},
8686
"EmptyPackage": {
@@ -108,7 +108,7 @@
108108
"$ref": "#/definitions/ExcludeFilterList"
109109
},
110110
"TypeDocComment": {
111-
"propertyOrder": 66,
111+
"propertyOrder": 68,
112112
"$ref": "#/definitions/ExcludeFilterList"
113113
},
114114
"MultipleVariableDeclarations": {
@@ -124,7 +124,7 @@
124124
"$ref": "#/definitions/ExcludeFilterList"
125125
},
126126
"WhitespaceAfter": {
127-
"propertyOrder": 72,
127+
"propertyOrder": 74,
128128
"$ref": "#/definitions/ExcludeFilterList"
129129
},
130130
"FileLength": {
@@ -151,11 +151,11 @@
151151
"propertyOrder": 2
152152
},
153153
"SeparatorWrap": {
154-
"propertyOrder": 56,
154+
"propertyOrder": 58,
155155
"$ref": "#/definitions/ExcludeFilterList"
156156
},
157157
"WhitespaceAround": {
158-
"propertyOrder": 73,
158+
"propertyOrder": 75,
159159
"$ref": "#/definitions/ExcludeFilterList"
160160
},
161161
"ListenerName": {
@@ -176,21 +176,25 @@
176176
"$ref": "#/definitions/ExcludeFilterList"
177177
},
178178
"SimplifyBooleanExpression": {
179-
"propertyOrder": 57,
179+
"propertyOrder": 59,
180180
"$ref": "#/definitions/ExcludeFilterList"
181181
},
182182
"SeparatorWhitespace": {
183-
"propertyOrder": 55,
183+
"propertyOrder": 57,
184184
"$ref": "#/definitions/ExcludeFilterList"
185185
},
186186
"TrailingWhitespace": {
187-
"propertyOrder": 64,
187+
"propertyOrder": 66,
188188
"$ref": "#/definitions/ExcludeFilterList"
189189
},
190190
"Dynamic": {
191191
"propertyOrder": 15,
192192
"$ref": "#/definitions/ExcludeFilterList"
193193
},
194+
"RedundantAccessMeta": {
195+
"propertyOrder": 51,
196+
"$ref": "#/definitions/ExcludeFilterList"
197+
},
194198
"LeftCurly": {
195199
"propertyOrder": 29,
196200
"$ref": "#/definitions/ExcludeFilterList"
@@ -204,7 +208,7 @@
204208
"$ref": "#/definitions/ExcludeFilterList"
205209
},
206210
"UnusedLocalVar": {
207-
"propertyOrder": 70,
211+
"propertyOrder": 72,
208212
"$ref": "#/definitions/ExcludeFilterList"
209213
},
210214
"IndentationCharacter": {
@@ -220,21 +224,25 @@
220224
"$ref": "#/definitions/ExcludeFilterList"
221225
},
222226
"TypeName": {
223-
"propertyOrder": 67,
227+
"propertyOrder": 69,
224228
"$ref": "#/definitions/ExcludeFilterList"
225229
},
226230
"InnerAssignment": {
227231
"propertyOrder": 27,
228232
"$ref": "#/definitions/ExcludeFilterList"
229233
},
230234
"UnnecessaryConstructor": {
231-
"propertyOrder": 68,
235+
"propertyOrder": 70,
232236
"$ref": "#/definitions/ExcludeFilterList"
233237
},
234238
"MultipleStringLiterals": {
235239
"propertyOrder": 39,
236240
"$ref": "#/definitions/ExcludeFilterList"
237241
},
242+
"RedundantAllowMeta": {
243+
"propertyOrder": 52,
244+
"$ref": "#/definitions/ExcludeFilterList"
245+
},
238246
"Anonymous": {
239247
"propertyOrder": 4,
240248
"$ref": "#/definitions/ExcludeFilterList"
@@ -244,11 +252,11 @@
244252
"$ref": "#/definitions/ExcludeFilterList"
245253
},
246254
"SimplifyBooleanReturn": {
247-
"propertyOrder": 58,
255+
"propertyOrder": 60,
248256
"$ref": "#/definitions/ExcludeFilterList"
249257
},
250258
"TODOComment": {
251-
"propertyOrder": 61,
259+
"propertyOrder": 63,
252260
"$ref": "#/definitions/ExcludeFilterList"
253261
},
254262
"ConstantName": {
@@ -264,15 +272,15 @@
264272
"$ref": "#/definitions/ExcludeFilterList"
265273
},
266274
"Trace": {
267-
"propertyOrder": 63,
275+
"propertyOrder": 65,
268276
"$ref": "#/definitions/ExcludeFilterList"
269277
},
270278
"NullableParameter": {
271279
"propertyOrder": 45,
272280
"$ref": "#/definitions/ExcludeFilterList"
273281
},
274282
"TabForAligning": {
275-
"propertyOrder": 62,
283+
"propertyOrder": 64,
276284
"$ref": "#/definitions/ExcludeFilterList"
277285
},
278286
"EmptyBlock": {
@@ -284,23 +292,23 @@
284292
"$ref": "#/definitions/ExcludeFilterList"
285293
},
286294
"StringLiteral": {
287-
"propertyOrder": 60,
295+
"propertyOrder": 62,
288296
"$ref": "#/definitions/ExcludeFilterList"
289297
},
290298
"ConditionalCompilation": {
291299
"propertyOrder": 10,
292300
"$ref": "#/definitions/ExcludeFilterList"
293301
},
294302
"Type": {
295-
"propertyOrder": 65,
303+
"propertyOrder": 67,
296304
"$ref": "#/definitions/ExcludeFilterList"
297305
},
298306
"OperatorWrap": {
299307
"propertyOrder": 47,
300308
"$ref": "#/definitions/ExcludeFilterList"
301309
},
302310
"ReturnCount": {
303-
"propertyOrder": 53,
311+
"propertyOrder": 55,
304312
"$ref": "#/definitions/ExcludeFilterList"
305313
},
306314
"Indentation": {
@@ -312,7 +320,7 @@
312320
"$ref": "#/definitions/ExcludeFilterList"
313321
},
314322
"Return": {
315-
"propertyOrder": 52,
323+
"propertyOrder": 54,
316324
"$ref": "#/definitions/ExcludeFilterList"
317325
},
318326
"LocalVariableName": {

0 commit comments

Comments
 (0)