Skip to content

Commit ddaa30e

Browse files
authored
New comment doc checks (#442)
* new check FieldDocComment * fixed Haxe4 coverage reports
1 parent 8be2cc5 commit ddaa30e

File tree

16 files changed

+949
-125
lines changed

16 files changed

+949
-125
lines changed

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@ matrix:
2626
- haxelib git tokentree https://github.com/HaxeCheckstyle/tokentree master src
2727
- haxelib git hxparse https://github.com/simn/hxparse
2828
- haxelib git haxeparser https://github.com/simn/haxeparser
29-
- haxelib git mcover https://github.com/massiveinteractive/mcover master src
29+
- haxelib git mcover https://github.com/AlexHaxe/mcover.git support-eval src
30+
- haxelib git munit https://github.com/AlexHaxe/MassiveUnit.git support-eval src
3031
- haxelib git hxnodejs https://github.com/HaxeFoundation/hxnodejs.git master
32+
- haxelib install mlib
3133
- haxelib install mconsole
3234
- haxelib install compiletime 2.6.0
3335
- haxelib install hxargs 3.0.2
34-
- haxelib install munit
3536
- sed -i 's/:3.3.0//' buildGlobal.hxml

CHANGES.md renamed to CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
## dev branch / next version (2.x.x)
22

33
- New check DocCommentStyle [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
4+
- New check FieldDocComment [#442](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/442)
45
- New check TypeDocComment [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
56
- Fixed handling of comments between types in ExtendedEmptyLines [#440](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/440)
7+
- Fixed unittest and coverage reporting for Haxe 4 [#442](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/442)
68
- Refactored `Checker.getLinePos` to use binary search, reduces runtime from O(N/2) to O(log N) [#439](https://github.com/HaxeCheckstyle/haxe-checkstyle/issues/439)
79

810
## version 2.4.1 (2018-06-14)
File renamed without changes.

checkstyle.json

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,14 @@
113113
},
114114
"type": "ExtendedEmptyLines"
115115
},
116+
{
117+
"type": "FieldDocComment",
118+
"props": {
119+
"tokens": [
120+
"CLASS_DEF"
121+
]
122+
}
123+
},
116124
{
117125
"props": {
118126
"max": 2000
@@ -589,6 +597,20 @@
589597
"checks/whitespace/EmptyLinesCheckTest:EmptyLinesCheckTests",
590598
"checks/whitespace/ExtendedEmptyLinesCheckTest:ExtendedEmptyLinesCheckTests"
591599
],
600+
"FieldDocComment": [
601+
"checkstyle/Main",
602+
"checkstyle/Checker",
603+
"checkstyle/ChecksInfo",
604+
"checkstyle/ParserQueue",
605+
"checkstyle/checks/Check",
606+
"config",
607+
"detect",
608+
"errors",
609+
"reporter",
610+
"schema",
611+
"test",
612+
"utils"
613+
],
592614
"LeftCurly": [
593615
"checkstyle/checks/metrics/CyclomaticComplexityCheck"
594616
],

gruntfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ function zipIt() {
4848
src: [
4949
"src/**",
5050
"resources/sample-config.json", "resources/logo.png", "resources/codeclimate_pr.png",
51-
"haxelib.json", "run.n", "README.md", "CHANGES.md", "LICENCE.md"
51+
"haxelib.json", "run.n", "README.md", "CHANGELOG.md", "LICENSE.md"
5252
],
5353
dest: "haxe-checkstyle.zip",
5454
compression: "DEFLATE",

haxelib.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@
1818
"AlexHaxe",
1919
"Gama11"
2020
],
21-
"releasenote": "added json schemas for config files; changes and fixes in preparation of vscode-checkstyle - see CHANGES",
21+
"releasenote": "new doc comments checks - see CHANGELOG",
2222
"version": "2.4.1",
2323
"url": "https://github.com/HaxeCheckstyle/haxe-checkstyle",
24-
"dependencies": {
25-
26-
}
24+
"dependencies": {}
2725
}

0 commit comments

Comments
 (0)