Replace Dynamic with Any where possible (#328)

Author: Gama11

src/checkstyle/Checker.hx

@@ -113,7 +113,7 @@ class Checker {
 				t = lexer.token(haxeparser.HaxeLexer.tok);
 			}
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			#if debug
 			Sys.println(e);
 			Sys.println("Stacktrace: " + CallStack.toString(CallStack.exceptionStack()));
@@ -146,7 +146,7 @@ class Checker {
 		try {
 			return parser.parse();
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			#if debug
 			Sys.println(e);
 			Sys.println("Stacktrace: " + CallStack.toString(CallStack.exceptionStack()));
@@ -199,7 +199,7 @@ class Checker {
 			makeTokens();
 			makeASTs();
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			for (reporter in reporters) {
 				reporter.addMessage(getErrorMessage(e, file.name, "Parsing"));
 				reporter.fileFinish(file);
@@ -262,7 +262,7 @@ class Checker {
 			if (checkForExclude(check.getModuleName())) return [];
 			return check.run(this);
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			for (reporter in reporters) reporter.addMessage(getErrorMessage(e, file.name, "Check " + check.getModuleName()));
 			return [];
 		}
@@ -286,7 +286,7 @@ class Checker {
 		return false;
 	}
 
-	function getErrorMessage(e:Dynamic, fileName:String, step:String):CheckMessage {
+	function getErrorMessage(e:Any, fileName:String, step:String):CheckMessage {
 		return {
 			fileName:fileName,
 			line:1,

src/checkstyle/Main.hx

@@ -186,7 +186,7 @@ class Main {
 			try {
 				check.configureProperty(prop, val);
 			}
-			catch (e:Dynamic) {
+			catch (e:Any) {
 				var message = 'Failed to configure $prop setting for ${check.getModuleName()}: ';
 				message += (Std.is(e, Error) ? (e:Error).message : Std.string(e));
 				failWith(message);
@@ -343,7 +343,7 @@ class Main {
 				files.push(path);
 			}
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			Sys.println("\nPath " + path + " not found.");
 		}
 	}
@@ -398,7 +398,7 @@ class Main {
 
 			new Main().run(args);
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			Sys.stderr().writeString(e + "\n");
 			Sys.stderr().writeString(CallStack.toString(CallStack.exceptionStack()) + "\n");
 		}

src/checkstyle/checks/Check.hx

@@ -25,7 +25,7 @@ class Check {
 		desc = haxe.rtti.Meta.getType(Type.getClass(this)).desc[0];
 	}
 
-	public function configureProperty(name:String, value:Dynamic) {
+	public function configureProperty(name:String, value:Any) {
 		Reflect.setField(this, name, value);
 	}
 

src/checkstyle/checks/Directive.hx

@@ -16,7 +16,7 @@ class DirectiveTools {
 		"any" => ANY
 	];
 
-	public static function fromDynamic(value:Dynamic):Directive {
+	public static function fromAny(value:Any):Directive {
 		return switch (Type.typeof(value)) {
 			case ValueType.TClass(String): getValidated(value);
 			//support for legacy configs when such settings were boolean

src/checkstyle/checks/imports/UnusedImportCheck.hx

@@ -8,7 +8,7 @@ import haxe.io.Path;
 class UnusedImportCheck extends Check {
 
 	public var ignoreModules:Array<String>;
-	public var moduleTypeMap:Dynamic;
+	public var moduleTypeMap:Any;
 
 	public function new() {
 		super(TOKEN);

src/checkstyle/checks/whitespace/SpacingCheck.hx

@@ -30,11 +30,11 @@ class SpacingCheck extends Check {
 		categories = [Category.STYLE, Category.CLARITY];
 	}
 
-	override public function configureProperty(name:String, value:Dynamic) {
+	override public function configureProperty(name:String, value:Any) {
 		var currentValue = Reflect.field(this, name);
 		switch (Type.typeof(currentValue)) {
 			case ValueType.TEnum(Directive):
-				Reflect.setField(this, name, DirectiveTools.fromDynamic(value));
+				Reflect.setField(this, name, DirectiveTools.fromAny(value));
 			case _:
 				super.configureProperty(name, value);
 		}

test/token/TokenTreeBuilderParsingTest.hx

@@ -27,7 +27,7 @@ class TokenTreeBuilderParsingTest extends haxe.unit.TestCase {
 		try {
 			builder = TestTokenTreeBuilder.parseCode(code);
 		}
-		catch (e:Dynamic) {
+		catch (e:Any) {
 			assertTrue(false, pos);
 		}
 		assertTrue(builder.isStreamEmpty(), pos);