Skip to content

Commit f7201ce

Browse files
committed
added override check test
1 parent e850518 commit f7201ce

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

checkstyle/checks/OverrideCheck.hx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ class OverrideCheck extends Check {
2121
}
2222

2323
function _overrideCheck(f:Field) {
24-
if (f.access.indexOf(AOverride) > 0) logPos('override access modifier should be the at the start of the function for better code readability \"${f.name}\"', f.pos, Reflect.field(SeverityLevel, severity));
24+
if (f.access.indexOf(AOverride) > 0) logPos('override access modifier should be the at the start of the function for better code readability: ${f.name}', f.pos, Reflect.field(SeverityLevel, severity));
2525
}
2626
}

test/OverrideCheckTest.hx

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
package ;
2+
3+
import checkstyle.checks.OverrideCheck;
4+
5+
class OverrideCheckTest extends CheckTestCase {
6+
7+
public function testCorrectOverride() {
8+
var msg = checkMessage(OverrideTests.TEST1, new OverrideCheck());
9+
assertEquals(msg, 'override access modifier should be the at the start of the function for better code readability: test');
10+
}
11+
12+
public function testWrongOverride() {
13+
var msg = checkMessage(OverrideTests.TEST2, new OverrideCheck());
14+
assertEquals(msg, '');
15+
}
16+
}
17+
18+
class OverrideTests {
19+
public static inline var TEST1:String = "
20+
class Test {
21+
public override function test() {}
22+
}";
23+
24+
public static inline var TEST2:String =
25+
"class Test {
26+
override public function test() {}
27+
}";
28+
}

0 commit comments

Comments
 (0)