a child class with a static var and a constructor should not trigger … (#335)

* a child class with a static var and a constructor should not trigger an unnecessary constructor warning

* updated Haxe version to 3.4.2

Author: AlexHaxe

.travis.yml

@@ -3,7 +3,7 @@ git:
 
 language: haxe
 haxe:
-  - 3.4.0
+  - 3.4.2
   - development
 install:
   - haxelib install haxeparser 3.3.0

src/checkstyle/checks/design/UnnecessaryConstructorCheck.hx

@@ -14,6 +14,9 @@ class UnnecessaryConstructorCheck extends Check {
 		var root:TokenTree = checker.getTokenTree();
 		var classes:Array<TokenTree> = root.filter([Kwd(KwdClass)], ALL);
 		for (cls in classes) {
+			if (extendsBaseClass(cls)) {
+				continue;
+			}
 			var acceptableTokens:Array<TokenTree> = cls.filter([
 				Kwd(KwdFunction),
 				Kwd(KwdVar)
@@ -40,4 +43,14 @@ class UnnecessaryConstructorCheck extends Check {
 			}
 		}
 	}
-}
+
+	function extendsBaseClass(cls:TokenTree):Bool {
+		var clsName:TokenTree = cls.getFirstChild();
+		for (child in clsName.children) {
+			if (child.is(Kwd(KwdExtends))) {
+				return true;
+			}
+		}
+		return false;
+	}
+}

test/checks/design/UnnecessaryConstructorCheckTest.hx

@@ -31,6 +31,10 @@ class UnnecessaryConstructorCheckTest extends CheckTestCase<UnnecessaryConstruct
 	public function testStaticOnlyWithNew() {
 		assertNoMsg(new UnnecessaryConstructorCheck(), TEST_STATIC_ONLY_WITH_NEW);
 	}
+
+	public function testChildClass() {
+		assertNoMsg(new UnnecessaryConstructorCheck(), TEST_CHILD_CLASS);
+	}
 }
 
 @:enum
@@ -104,4 +108,15 @@ abstract UnnecessaryConstructorCheckTests(String) to String {
 			VAR1 = new String();
 		}
 	}";
-}
+
+	var TEST_CHILD_CLASS = "
+	class Test extends Base
+	{
+		public static var VAR1:String = 'test';
+
+		public function new()
+		{
+			super(VAR1);
+		}
+	}";
+}