removed premature abstract cast while typing against enum (fixes #10173)

Author: RealyUniqueName

extra/CHANGES.txt

@@ -9,6 +9,7 @@
 	all : fixed subtypes in `expr is Module.SubType` expressions (#10174)
 	all : fixed typing chains of calls with constrained type params (#10198)
 	all : fixed mixed constraints of anonymous structures and other types (#10162)
+	all : fixed operator overloading for enum abstracts (#10173)
 	hl : fixed debugging of `catch` blocks (#10109)
 	jvm : fixed manifest generation for cases with a lot of jar libraries (#10157)
 	js : fixed extending extern classes for es5 (#10192)

src/typing/typer.ml

@@ -108,11 +108,7 @@ let maybe_type_against_enum ctx f with_type iscall p =
 							(try Type.unify t' t with Unify_error _ -> ());
 							AKExpr e
 						| _ ->
-							if iscall then
-								AKExpr e
-							else begin
-								AKExpr (AbstractCast.cast_or_unify ctx t e e.epos)
-							end
+							AKExpr e
 					end
 				| _ -> e (* ??? *)
 			end

tests/unit/src/unit/issues/Issue10173.hx

@@ -0,0 +1,23 @@
+package unit.issues;
+
+class Issue10173 extends Test {
+	function test() {
+		var foo:Foo = Bar;
+		var i = 9999;
+		t(foo == i);
+		foo = Baz;
+		f(foo == i);
+	}
+}
+
+private enum abstract Foo(Int) to Int {
+	var Bar;
+	var Baz;
+
+	@:op(A == B) public static function eqInt(lhs:Foo, rhs:Int):Bool {
+		return switch lhs {
+			case Bar: true;
+			case Baz: false;
+		}
+	}
+}