version without parentheses

Author: RblSb

src-json/warning.json

@@ -75,7 +75,7 @@
 	},
 	{
 		"name": "WConditionAssign",
-		"doc": "Using the result of an assignment as a condition without parentheses",
+		"doc": "Using the result of an assignment as a condition",
 		"parent": "WTyper"
 	},
 	{

src/typing/typer.ml

@@ -1475,18 +1475,15 @@ and make_if_then_else ctx e0 e1 e2 with_type p =
 	mk (TIf (e0,e1,Some e2)) t p
 
 and warn_assign_in_condition ctx cond =
-	let rec skip_without_parentheses e = match e.eexpr with
-		| TMeta(_,e1) | TBlock [e1] | TCast(e1,None) -> skip e1
-		| _ -> e in
 	let rec is_assign e =
-		let e = skip_without_parentheses e in
+		let e = Texpr.skip e in
 		match e.eexpr with
 			| TBinop (OpAssign, _, rhs) ->
 				let t = follow rhs.etype in
 				let is_bool = ExtType.is_bool t in
-				let is_null = match (skip_without_parentheses rhs).eexpr with | TConst TNull -> true | _ -> false in
+				let is_null = match (Texpr.skip rhs).eexpr with | TConst TNull -> true | _ -> false in
 				if is_bool || is_null then
-					warning ctx WConditionAssign "Using the result of an assignment as a condition without parentheses" e.epos
+					warning ctx WConditionAssign "Using the result of an assignment as a condition" e.epos
 			| TBinop ((OpBoolAnd | OpBoolOr), e1, e2) ->
 				is_assign e1;
 				is_assign e2;
@@ -1504,7 +1501,6 @@ and type_if ctx e e1 e2 with_type is_ternary p =
 	let e = type_expr ctx e WithType.value in
 	if is_ternary then begin match e.eexpr with
 		| TConst TNull -> raise_typing_error "Cannot use null as ternary condition" e.epos
-		| TParenthesis e -> warn_assign_in_condition ctx e;
 		| _ -> ()
 	end;
 	warn_assign_in_condition ctx e;