File tree Expand file tree Collapse file tree 2 files changed +7
-7
lines changed
Expand file tree Collapse file tree 2 files changed +7
-7
lines changed Original file line number Diff line number Diff line change @@ -27,19 +27,17 @@ package sys.thread;
2727#end
2828
2929/**
30- Creates thread local storage.
31-
32- (hl) Warning: At the moment `Tls` does not protect the value from being
33- garbage collected. Keep the value reachable to avoid crashes.
30+ A thread-local storage to store per-thread values.
3431**/
3532extern class Tls <T > {
3633 var value (get , set ): T ;
3734
3835 /**
3936 Creates thread local storage. This is placeholder that can store
4037 a value that will be different depending on the local thread.
41- Set the tls value to `null` before exiting the thread
42- or the memory will never be collected.
38+
39+ It is good practice to set the value to `null` when the thread exits.
40+ Otherwise, it might not be garbage-collected on some targets.
4341 **/
4442 function new (): Void ;
4543}
Original file line number Diff line number Diff line change @@ -66,7 +66,9 @@ function main() {
6666 new TestHashMap (),
6767 new TestRest (),
6868 #if (!php && !lua)
69- new TestHttps (),
69+ /* This is annoying and causes spurious CI failures. Let's just make an effort to
70+ not break it! */
71+ // new TestHttps(),
7072 #end
7173 /* Every target struggles with these tests. We can occasionally enable them when
7274 making related changes, but otherwise this is not worth the CI time. */
You can’t perform that action at this time.
0 commit comments