forbid return outside functions (closes #9659) (#9665)

Author: RealyUniqueName

extra/CHANGES.txt

@@ -1,5 +1,11 @@
 2020-XX-XX 4.1.3
 
+	General improvements:
+
+	all : added an error on `return` outside of a function (#9659)
+	php : support @:native("") for extern classes (#6448)
+	python : support @:native("") for extern classes (#6448)
+
 	Bugfixes:
 
 	all : fixed compilation server bug caused by removing `inline` from a method (#9690)
@@ -8,9 +14,7 @@
 	flash : fixed var shadowing issue for variables captured in a closure inside of a loop (#9624)
 	flash : fixed `VerifyError` exception when `Void` end up as an argument type after inlining (#9678)
 	php : fixed runtime error "cannot use temporary expression in write context" for call arguments passed by reference
-	php : support @:native("") for extern classes (#6448)
 	cs : fixed `cs.Lib.rethrow` (#9738)
-	python : support @:native("") for extern classes (#6448)
 	nullsafety: fixed `@:nullSafety(Off)` in closures inside of constructors (#9643)
 	nullsafety: fixed "Type not found NullSafetyMode_Impl_" (#9483)
 

src/context/typecore.ml

@@ -122,6 +122,7 @@ and typer = {
 	(* per-function *)
 	mutable curfield : tclass_field;
 	mutable untyped : bool;
+	mutable in_function : bool;
 	mutable in_loop : bool;
 	mutable in_display : bool;
 	mutable in_macro : bool;

src/typing/typeloadFunction.ml

@@ -45,12 +45,14 @@ let save_field_state ctx =
 	let old_ret = ctx.ret in
 	let old_fun = ctx.curfun in
 	let old_opened = ctx.opened in
+	let old_in_function = ctx.in_function in
 	let locals = ctx.locals in
 	(fun () ->
 		ctx.locals <- locals;
 		ctx.ret <- old_ret;
 		ctx.curfun <- old_fun;
 		ctx.opened <- old_opened;
+		ctx.in_function <- old_in_function;
 	)
 
 let type_var_field ctx t e stat do_display p =
@@ -105,6 +107,7 @@ let type_function ctx args ret fmode f do_display p =
 		if n = "this" then v.v_meta <- (Meta.This,[],null_pos) :: v.v_meta;
 		v,c
 	) args f.f_args in
+	ctx.in_function <- true;
 	ctx.curfun <- fmode;
 	ctx.ret <- ret;
 	ctx.opened <- [];

src/typing/typeloadModule.ml

@@ -879,6 +879,7 @@ let type_types_into_module ctx m tdecls p =
 		untyped = false;
 		in_macro = ctx.in_macro;
 		in_display = false;
+		in_function = false;
 		in_loop = false;
 		opened = [];
 		in_call_args = false;

src/typing/typer.ml

@@ -2562,7 +2562,18 @@ and type_expr ?(mode=MGet) ctx (e,p) (with_type:WithType.t) =
 		let e = Matcher.Match.match_expr ctx e1 cases def with_type false p in
 		wrap e
 	| EReturn e ->
-		type_return ctx e with_type p
+		if not ctx.in_function then begin
+			display_error ctx "Return outside function" p;
+			match e with
+			| None ->
+				Texpr.Builder.make_null t_dynamic p
+			| Some e ->
+				(* type the return expression to see if there are more errors
+				   as well as use its type as if there was no `return`, since
+				   that is most likely what was meant *)
+				type_expr ctx e WithType.value
+		end else
+			type_return ctx e with_type p
 	| EBreak ->
 		if not ctx.in_loop then display_error ctx "Break outside loop" p;
 		mk TBreak t_dynamic p
@@ -2666,6 +2677,7 @@ let rec create com =
 		macro_depth = 0;
 		untyped = false;
 		curfun = FunStatic;
+		in_function = false;
 		in_loop = false;
 		in_display = false;
 		get_build_infos = (fun() -> None);

tests/misc/projects/Issue9659/Main.hx

@@ -0,0 +1,7 @@
+class Main {
+	static var field = return 3;
+
+	static function main() {
+		var x:String = field;
+	}
+}

tests/misc/projects/Issue9659/compile-fail.hxml

@@ -0,0 +1 @@
+--main Main

tests/misc/projects/Issue9659/compile-fail.hxml.stderr

@@ -0,0 +1,2 @@
+Main.hx:2: characters 21-29 : Return outside function
+Main.hx:5: characters 3-24 : Int should be String