Skip to content

Commit ece313f

Browse files
committed
chore: update rest of non-astro apps to use vite@v7
- @lib/sass-utils: replace `@import` rule by `@use`. needed since `sass@v1.80.0`
1 parent ce7cf25 commit ece313f

File tree

14 files changed

+153
-495
lines changed

14 files changed

+153
-495
lines changed

_templates/app/react/package.json.hygen

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ to: apps/<%= name %>/package.json
2828
"react-dom": "catalog:"
2929
},
3030
"devDependencies": {
31-
"@vitejs/plugin-react": "catalog:",
32-
"sass": "catalog:",
33-
"typescript": "catalog:",
34-
"vite": "catalog:"
31+
"@vitejs/plugin-react": "catalog:vite7",
32+
"sass": "catalog:vite7",
33+
"typescript": "catalog:vite7",
34+
"vite": "catalog:vite7"
3535
}
3636
}

legacy/country-quiz/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@
2828
"zustand": "catalog:"
2929
},
3030
"devDependencies": {
31-
"@vitejs/plugin-react": "catalog:",
32-
"sass": "catalog:",
33-
"typescript": "catalog:",
34-
"vite": "catalog:",
35-
"vitest": "catalog:",
31+
"@vitejs/plugin-react": "catalog:vite7",
32+
"sass": "catalog:vite7",
33+
"typescript": "catalog:vite7",
34+
"vite": "catalog:vite7",
35+
"vitest": "catalog:vite7",
3636
"vite-plugin-hrc-import": "catalog:"
3737
},
3838
"engines": {

legacy/country-quiz/vite.config.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import hrcImportPlugin from 'vite-plugin-hrc-import'
55

66
// https://vitejs.dev/config/
77
export default defineConfig({
8+
// NOTE: `vite-plugin-hrc-import` IS COMPATIBLE with vite@v7, but requires
9+
// updating its `peerDependencies` to allow `vite@6` and `vite@7` to suppress
10+
// `unmet peer` warnings.
811
plugins: [react(), hrcImportPlugin()],
912
base: '/dev-challenges/legacy/country-quiz',
1013
build: {
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
@import './colors.scss';
1+
@use './colors.scss';
22

3-
@import './label.scss';
4-
@import './input.scss';
5-
@import './helper-text.scss';
6-
@import './icon.scss'
3+
@use './label.scss';
4+
@use './input.scss';
5+
@use './helper-text.scss';
6+
@use './icon.scss'

legacy/input-component/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@
2727
},
2828
"devDependencies": {
2929
"@hrc/type-utils": "catalog:",
30-
"@vitejs/plugin-react": "catalog:",
31-
"sass": "catalog:",
32-
"typescript": "catalog:",
33-
"vite": "catalog:"
30+
"@vitejs/plugin-react": "catalog:vite7",
31+
"sass": "catalog:vite7",
32+
"typescript": "catalog:vite7",
33+
"vite": "catalog:vite7"
3434
},
3535
"engines": {
3636
"node": ">=18",

legacy/todo-app/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@
2727
"zustand": "catalog:"
2828
},
2929
"devDependencies": {
30-
"@vitejs/plugin-react": "catalog:",
31-
"sass": "catalog:",
32-
"typescript": "catalog:",
33-
"vite": "catalog:",
30+
"@vitejs/plugin-react": "catalog:vite7",
31+
"sass": "catalog:vite7",
32+
"typescript": "catalog:vite7",
33+
"vite": "catalog:vite7",
3434
"vite-plugin-hrc-import": "catalog:"
3535
},
3636
"engines": {

legacy/windbnb/TODO.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1+
# TODO
2+
3+
- use smaller images for lower screen sizes
4+
- zoom-in image on hover
5+
- try to add a background to `<StayCard />` on hover
16
- Apply lazy load to `<SearchDrawer />`

legacy/windbnb/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@
3030
},
3131
"devDependencies": {
3232
"@hrc/type-utils": "catalog:",
33-
"@vitejs/plugin-react": "catalog:",
34-
"sass": "catalog:",
35-
"typescript": "catalog:",
36-
"vite": "catalog:"
33+
"@vitejs/plugin-react": "catalog:vite7",
34+
"sass": "catalog:vite7",
35+
"typescript": "catalog:vite7",
36+
"vite": "catalog:vite7"
3737
},
3838
"engines": {
3939
"node": ">=18",

libs/sass-utils/TODO.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# TODO
2+
3+
## font/sizes
4+
5+
- export `css` variables as `scss` variables. allows to use only needed sizes
6+
7+
- add `SassDoc` comments to show equivalent `px` values:
8+
9+
```scss
10+
/// 10px
11+
$fs-000: 0.625rem;
12+
```
13+
14+
- `@use` these `scss` variables in `static` and `fluid` variants. requires
15+
transforming them from `.css` to `.scss`

libs/sass-utils/font/index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
@import 'sizes';
1+
@use 'sizes';

0 commit comments

Comments
 (0)