hdr_historgram_log: fix 3 memory leaks on histogram-counts

DavidKorczynski · mikeb01 · commit 9594a76755fd · 2024-01-15T08:13:48.000-11:00
The fuzzer from #120 found some leaks when the `hdr_decode_compressed*` functions call `hdr_init` but later fails and cleans up `h` by way of `hdr_free(h)`. The problem is that the `counts` field on the histogram is leaked, which is allocated https://github.com/HdrHistogram/HdrHistogram_c/blob/8dcce8f68512fca460b171bccc3a5afce0048779/src/hdr_histogram.c#L424 and assigned to the `counts` field here: https://github.com/HdrHistogram/HdrHistogram_c/blob/8dcce8f68512fca460b171bccc3a5afce0048779/src/hdr_histogram.c#L437 Signed-off-by: David Korczynski <david@adalogics.com>
diff --git a/src/hdr_histogram_log.c b/src/hdr_histogram_log.c
@@ -442,7 +442,7 @@ static int hdr_decode_compressed_v0(
 
     if (result != 0)
     {
-        hdr_free(h);
+        hdr_close(h);
     }
     else if (NULL == *histogram)
     {
@@ -547,7 +547,7 @@ static int hdr_decode_compressed_v1(
 
     if (result != 0)
     {
-        hdr_free(h);
+        hdr_close(h);
     }
     else if (NULL == *histogram)
     {
@@ -649,7 +649,7 @@ static int hdr_decode_compressed_v2(
 
     if (result != 0)
     {
-        hdr_free(h);
+        hdr_close(h);
     }
     else if (NULL == *histogram)
     {

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ static int hdr_decode_compressed_v0(`
`442`	`442`
`443`	`443`	`if (result != 0)`
`444`	`444`	`{`
`445`		`- hdr_free(h);`
	`445`	`+ hdr_close(h);`
`446`	`446`	`}`
`447`	`447`	`else if (NULL == *histogram)`
`448`	`448`	`{`
`@@ -547,7 +547,7 @@ static int hdr_decode_compressed_v1(`
`547`	`547`
`548`	`548`	`if (result != 0)`
`549`	`549`	`{`
`550`		`- hdr_free(h);`
	`550`	`+ hdr_close(h);`
`551`	`551`	`}`
`552`	`552`	`else if (NULL == *histogram)`
`553`	`553`	`{`
`@@ -649,7 +649,7 @@ static int hdr_decode_compressed_v2(`
`649`	`649`
`650`	`650`	`if (result != 0)`
`651`	`651`	`{`
`652`		`- hdr_free(h);`
	`652`	`+ hdr_close(h);`
`653`	`653`	`}`
`654`	`654`	`else if (NULL == *histogram)`
`655`	`655`	`{`