Skip to content

Commit 7de3c99

Browse files
Fix HistogramLogWriter.OutputStartTime nanosecond conversion (#54)
* Fix HistogramLogWriter.OutputStartTime It should multiply it by 1e6 not 1e9 * Only triggering fmt when needed * reverted make changes * Only triggering fmt when needed --------- Co-authored-by: fcostaoliveira <filipe@redis.com>
1 parent 375461c commit 7de3c99

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ get:
3838
fmt: .prepare-golangci
3939
@$(BIN_DIR)/golangci-lint run --fix
4040

41-
test: get fmt
41+
test: get
4242
$(GOTEST) -count=1 ./...
4343

4444
coverage: get test

bin/golangci-lint

36.8 MB
Binary file not shown.

log_writer.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,9 @@ func (lw *HistogramLogWriter) OutputIntervalHistogramWithLogOptions(histogram *H
109109
// Line starts with the leading text '#[StartTime:'
110110
func (lw *HistogramLogWriter) OutputStartTime(msec int64) (err error) {
111111
secs := msec / 1000
112-
iso_str := time.Unix(secs, msec%int64(1000)*int64(1000000000)).Format(time.RFC3339)
113-
_, err = fmt.Fprintf(lw.log, "#[StartTime: %d (seconds since epoch), %s]\n", secs, iso_str)
112+
nsecs := (msec % 1000) * int64(time.Millisecond) // 1 ms = 1e6 ns
113+
isoStr := time.Unix(secs, nsecs).Format(time.RFC3339)
114+
_, err = fmt.Fprintf(lw.log, "#[StartTime: %d (seconds since epoch), %s]\n", secs, isoStr)
114115
return
115116
}
116117

0 commit comments

Comments
 (0)