Skip to content

networkAllow not tested on failing @condSend() variable writes  #31

@trethaller

Description

@trethaller

Currently clients are allowed to modify vars marked as condSend(false) without any error:

		if( t.condSend.expr.match(EConst(CIdent("false"))) )
			return macro {}; // no marking
		var condSend = loop(t.condSend);
		needRef = true;
		mark = macro if( $condSend ) { this.$rname = this.$fname; $mark; };

We discussed removing the "no marking" optimization and adding a checkWrite() call in the else case so all failing condSend() are properly tested on clients.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions