refactor: return non-collectible cards by default

...anywhere but in GetFromName.

Author: beheh

HearthDb.Tests/UnitTest1.cs

@@ -59,7 +59,7 @@ public void TestMechanics()
 		[TestMethod]
 		public void TestCardText()
 		{
-			var lucentbark = Cards.GetFromDbfId(51796, false);
+			var lucentbark = Cards.GetFromDbfId(51796);
 			System.Console.WriteLine(lucentbark.Text);
 			Assert.IsTrue(lucentbark.Text.Contains("(5 left!)"));
 

HearthDb/Cards.cs

@@ -59,7 +59,7 @@ static Cards()
 		public static Card GetFromName(string name, Locale lang, bool collectible = true)
 			=> (collectible ? Collectible : All).Values.FirstOrDefault(x => x.GetLocName(lang)?.Equals(name, StringComparison.InvariantCultureIgnoreCase) ?? false);
 
-		public static Card GetFromDbfId(int dbfId, bool collectible = true)
+		public static Card GetFromDbfId(int dbfId, bool collectible = false)
 			=> (collectible ? CollectibleByDbfId : AllByDbfId).TryGetValue(dbfId, out var card) ? card : null;
 
 		private static bool IsDeflectOBot(Entity entity) => entity.CardId == CardIds.NonCollectible.Neutral.DeflectOBot || entity.CardId == CardIds.NonCollectible.Neutral.DeflectOBotTavernBrawl;

HearthDb/Deckstrings/Deck.cs

@@ -46,7 +46,7 @@ public class Deck
 		/// <summary>
 		/// Gets the card object for the given HeroDbfId
 		/// </summary>
-		public Card GetHero() => Cards.GetFromDbfId(HeroDbfId, false);
+		public Card GetHero() => Cards.GetFromDbfId(HeroDbfId);
 
 		/// <summary>
 		/// Converts (DbfId, Count) dictionary to (CardObject, Count).
@@ -61,10 +61,10 @@ public Dictionary<Card, int> GetCards() => CardDbfIds
 		public Dictionary<Card, Dictionary<Card, int>> GetSideboards() => Sideboards
 			.Select(x => new
 			{
-				Owner = Cards.GetFromDbfId(x.Key), 
+				Owner = Cards.GetFromDbfId(x.Key),
 				Sideboard = x.Value.Select(s => new
 				{
-					Card = Cards.GetFromDbfId(s.Key), 
+					Card = Cards.GetFromDbfId(s.Key),
 					Count = s.Value
 				}).Where(s => s.Card != null).ToDictionary(x => x.Card, x => x.Count)
 			})