fix(clickhouse-driver): Fix headers check (cube-js#9746)

KSDaemon · Frank-TXS · commit 917b683ed15b · 2025-08-05T10:33:20.000+02:00
diff --git a/packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts b/packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts
@@ -268,7 +268,9 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface {
           abort_signal: signal,
         });
 
-        if (resultSet.response_headers['x-clickhouse-format'] !== format) {
+        // response_headers['x-clickhouse-format'] is optional, but if it exists,
+        // it should match the requested format.
+        if (resultSet.response_headers['x-clickhouse-format'] && resultSet.response_headers['x-clickhouse-format'] !== format) {
           throw new Error(`Unexpected x-clickhouse-format in response: expected ${format}, received ${resultSet.response_headers['x-clickhouse-format']}`);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,9 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface {`
`268`	`268`	`abort_signal: signal,`
`269`	`269`	`});`
`270`	`270`
`271`		`- if (resultSet.response_headers['x-clickhouse-format'] !== format) {`
	`271`	`+ // response_headers['x-clickhouse-format'] is optional, but if it exists,`
	`272`	`+ // it should match the requested format.`
	`273`	`+ if (resultSet.response_headers['x-clickhouse-format'] && resultSet.response_headers['x-clickhouse-format'] !== format) {`
`272`	`274`	throw new Error(`Unexpected x-clickhouse-format in response: expected ${format}, received ${resultSet.response_headers['x-clickhouse-format']}`);
`273`	`275`	`}`
`274`	`276`