Fix for #893. HeliosVisualRenderer had old code to RenderToBitmap the image, however this is not needed and should have been replaced by a DrawRectangle using a VisualBrush instead.

Author: BlueFinBima

Aircraft AH-64D Plugin/Gauges/IAS/IAS.cs

@@ -24,9 +24,9 @@ namespace GadrocsWorkshop.Helios.Gauges.AH64D
     [HeliosControl("Helios.AH64D.IAS", "Standby IAS Gauge", "AH-64D", typeof(GaugeRenderer),HeliosControlFlags.NotShownInUI)]
     public class IAS : BaseGauge
     {
-        private HeliosValue _indicatedAirSpeed;
-        private GaugeNeedle _needle;
-        private CalibrationPointCollectionDouble _needleCalibration;
+        private readonly HeliosValue _indicatedAirSpeed;
+        private readonly GaugeNeedle _needle;
+        private readonly CalibrationPointCollectionDouble _needleCalibration;
 
         public IAS()
             : base("Standby IAS Gauge", new Size(300, 300))

Helios/Controls/CustomGaugeRenderer.cs

@@ -25,7 +25,7 @@ public class CustomGaugeRenderer : HeliosVisualRenderer
         private Rect _imageRect, _backgroundRect;
         private Point _center, _nextToCenter;
         private double _rotation;
-        private readonly Brush _scopeBrush = new SolidColorBrush(Color.FromRgb(255, 0, 0));
+        private readonly Brush _scopeBrush = new SolidColorBrush(Color.FromRgb(127, 0, 0));
         private readonly Pen _scopePen;
         private CustomGauge _gauge;
 

Helios/Gauges/GaugeNeedle.cs

@@ -133,7 +133,7 @@ public double VerticalOffset
 
         #endregion
 
-        protected override void OnRender(System.Windows.Media.DrawingContext drawingContext)
+        protected override void OnRender(DrawingContext drawingContext)
         {
             TransformGroup transform = new TransformGroup();
             transform.Children.Add(new TranslateTransform((-_center.X + HorizontalOffset) * _xScale, (-_center.Y + VerticalOffset) * _yScale));

Helios/HeliosVisualRenderer.cs

@@ -120,9 +120,15 @@ private void CheckRefresh()
 
         protected virtual void OnRender(DrawingContext drawingContext, double scaleX, double scaleY)
         {
-            drawingContext.PushTransform(new ScaleTransform(scaleX, scaleY));
+            if (scaleX != 1d || scaleY != 1d)
+            {
+                drawingContext.PushTransform(new ScaleTransform(scaleX, scaleY));
+            }
             OnRender(drawingContext);
-            drawingContext.Pop();
+            if (scaleX != 1d || scaleY != 1d)
+            {
+                drawingContext.Pop();
+            }
         }
 
 
@@ -152,7 +158,7 @@ private void UpdateTransform()
         /// <param name="drawingContext"></param>
         /// <param name="image"></param>
         /// <param name="imageRectangle"></param>
-        private void RenderEffect(DrawingContext drawingContext, ImageSource image, Rect imageRectangle)
+        private void RenderEffect(DrawingContext drawingContext, DrawingVisual image, Rect imageRectangle)
         {
             // ShaderEffect can be deleted in Profile Editor so we always need to get it from ProfileManager
             if (!_designTimeChecked)
@@ -174,19 +180,12 @@ private void RenderEffect(DrawingContext drawingContext, ImageSource image, Rect
                 _effect = ConfigManager.ProfileManager.CurrentEffect as Effects.ColorAdjustEffect;
             }
 
-            System.Windows.Controls.Image imageControl = new System.Windows.Controls.Image
-            {
-                Source = image,
-                Width = image != null ? image.Width : 0,
-                Height = image != null ? image.Width : 0,
-
-            };
             if (!Visual.EffectsExclusion)
             {
-                imageControl.Effect = _effect;
+                image.Effect = _effect;
             }
-            VisualBrush visualBrush = new VisualBrush(imageControl);
-            drawingContext.DrawRectangle(visualBrush, null, imageRectangle);
+
+            drawingContext.DrawRectangle(new VisualBrush(image), null, imageRectangle);
         }
 
         /// <summary>
@@ -197,16 +196,12 @@ private void RenderEffect(DrawingContext drawingContext, ImageSource image, Rect
         /// <param name="rectangle"></param>
         protected void RenderVisual(DrawingContext drawingContext, DrawingVisual visual, Rect rectangle)
         {
-            if(visual.ContentBounds.IsEmpty || rectangle.Width == 0 || rectangle.Height == 0) { return; }
-            RenderTargetBitmap rtb = new RenderTargetBitmap(Convert.ToInt32(rectangle.Width), Convert.ToInt32(rectangle.Height), 96, 96, PixelFormats.Pbgra32);
-            rtb.Render(visual);
-            //drawingContext.DrawImage(rtb, rectangle);
-            RenderEffect(drawingContext, rtb, rectangle);
-
-            // Address MILERR_WIN32ERROR (Exception from HRESULT: 0x88980003 in PresentationCore 
-            (rtb.GetType().GetField("_renderTargetBitmap", BindingFlags.Instance | BindingFlags.NonPublic)?
-.GetValue(rtb) as IDisposable)?.Dispose();  // from https://github.com/dotnet/wpf/issues/3067
+            if(visual.ContentBounds.IsEmpty || rectangle.Width == 0 || rectangle.Height == 0) 
+            { 
+                return; 
+            }
 
+            RenderEffect(drawingContext, visual, rectangle);
         }
 
         #region Draw Proxies