Merge pull request #264 from rackerlabs/rollup-eslint

feat(rollup-plugin-eslint): added eslint plugin with rollup

Author: Catherine Siller

lib/compile.js

@@ -45,7 +45,13 @@ async function compileScripts () {
     console.log('SRC: Compiling JavaScript');
 
     // TODO: convert to npm script
-    await exec(`yarn rollup`, { cwd: CONFIG.root });
+    await exec(`yarn rollup`, { cwd: CONFIG.root }, function(error, stderr){
+        if (error) {
+            console.error(`exec error: ${error}`);
+            return;
+        }
+        console.log(`stderr: ${stderr}`);
+    });
 }//compileScripts()
 
 async function compileAll () {

package.json

@@ -42,6 +42,7 @@
     "rollup": "0.60",
     "rollup-plugin-babel": "^3.0.2",
     "rollup-plugin-commonjs": "9.x",
+    "rollup-plugin-eslint": "^4.0.0",
     "rollup-plugin-html": "^0.2.1",
     "rollup-plugin-json": "3.x",
     "rollup-plugin-node-resolve": "^3.0.0",

rollup.config.js

@@ -7,6 +7,7 @@ import { minify } from 'uglify-es';
 import less from './lib/rollup-plugin-less';
 import resolve from 'rollup-plugin-node-resolve';
 import commonjs from 'rollup-plugin-commonjs';
+import eslint from 'rollup-plugin-eslint';
 
 let htmlPlugin = html ({
     include: [
@@ -31,6 +32,12 @@ let lessPlugin = less({
     }
 });
 
+let eslintPlugin = eslint({
+    include: [
+        '**/*.js',
+    ],
+});
+
 // Intro/Outro placed INSIDE the applied dependency function
 let intro = `window.addEventListener('WebComponentsReady', function () {`;
 let outro = `});`;
@@ -81,6 +88,7 @@ export default [
             commonjs(),
             htmlPlugin,
             lessPlugin,
+            eslintPlugin,
             babelPlugin,
             uglify({}, minify),
         ],

src/helix-ui/elements/HXAccordionPanelElement.js

@@ -29,7 +29,7 @@ import shadowStyles from './HXAccordionPanelElement.less';
  */
 export class HXAccordionPanelElement extends HXElement {
     static get is () {
-        return `hx-accordion-panel`;
+        return 'hx-accordion-panel';
     }
 
     static get template () {

src/helix-ui/elements/HXAlertElement.js

@@ -36,7 +36,7 @@ const ICONS = {
  */
 export class HXAlertElement extends HXElement {
     static get is () {
-        return `hx-alert`;
+        return 'hx-alert';
     }
 
     static get template () {

src/helix-ui/elements/HXBusyElement.js

@@ -13,7 +13,7 @@ export class HXBusyElement extends HXElement {
     }
 
     static get template () {
-        return ``;
+        return '';
     }
 
     connectedCallback () {

src/helix-ui/elements/HXCheckboxElement.js

@@ -1,5 +1,4 @@
 import { HXElement } from './HXElement';
-import { KEYS } from '../util';
 import shadowMarkup from './HXCheckboxElement.html';
 import shadowStyles from './HXCheckboxElement.less';
 

src/helix-ui/elements/HXDisclosureElement.js

@@ -14,9 +14,7 @@ export class HXDisclosureElement extends HXElement {
     }
 
     static get observedAttributes () {
-        return super.observedAttributes.concat([
-            'aria-expanded',
-        ]);
+        return super.observedAttributes.concat([ 'aria-expanded' ]);
     }
 
     constructor () {
@@ -61,8 +59,7 @@ export class HXDisclosureElement extends HXElement {
     attributeChangedCallback (attr, oldVal, newVal) {
         super.attributeChangedCallback(attr, oldVal, newVal);
 
-        const hasValue = (newVal !== null);
-        switch(attr) {
+        switch (attr) {
             case 'aria-expanded':
                 if (this.target) {
                     let setTo = (newVal === 'true');

src/helix-ui/elements/HXPillElement.js

@@ -19,7 +19,7 @@ import shadowStyles from './HXPillElement.less';
  */
 export class HXPillElement extends HXElement {
     static get is () {
-        return `hx-pill`;
+        return 'hx-pill';
     }
 
     static get template () {

src/helix-ui/elements/HXToastElement.js

@@ -62,10 +62,7 @@ export class HXToastElement extends HXElement {
     }
 
     static get observedAttributes () {
-        return [
-            'cta',
-            'type',
-        ];
+        return [ 'cta', 'type' ];
     }//observedAttributes
 
     attributeChangedCallback (attr, oldVal, newVal) {