Skip to content

Commit c4284fb

Browse files
author
Ryan A. Johnson
committed
refactor(icons): rename export to upload
* rename 'export' icon to 'upload' * Update icon metadata * add minver to 0.7.0 icons * replace 'alias' with 'replacement' for icons that are deprecated * Update docs to show "replace with ..." for deprecated icons
1 parent 0d568e8 commit c4284fb

File tree

4 files changed

+30
-6
lines changed

4 files changed

+30
-6
lines changed

docs/_data/icons.json5

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,16 @@
110110
{
111111
name: 'export',
112112
minver: '0.1.4',
113+
deprecated: true,
114+
replacement: 'upload',
113115
},
114116
{
115117
name: 'external-link',
116118
minver: '0.1.10',
117119
},
118120
{
119121
name: 'file',
122+
minver: '0.7.0',
120123
keywords: [
121124
'blank',
122125
'paper',
@@ -131,9 +134,11 @@
131134
},
132135
{
133136
name: 'flag',
137+
minver: '0.7.0',
134138
},
135139
{
136140
name: 'globe',
141+
minver: '0.7.0',
137142
},
138143
{
139144
name: 'help-circle',
@@ -160,8 +165,8 @@
160165
{
161166
name: 'input-url',
162167
minver: '0.1.0',
163-
alias: 'globe',
164168
deprecated: true,
169+
replacement: 'globe',
165170
},
166171
{
167172
name: 'kbd-arrow-down',
@@ -226,6 +231,7 @@
226231
},
227232
{
228233
name: 'key',
234+
minver: '0.7.0',
229235
keywords: [
230236
'ca-bundle',
231237
'cer',
@@ -256,6 +262,7 @@
256262
},
257263
{
258264
name: 'mime-archive',
265+
minver: '0.7.0',
259266
keywords: [
260267
'7z',
261268
'apk',
@@ -270,6 +277,7 @@
270277
},
271278
{
272279
name: 'mime-audio',
280+
minver: '0.7.0',
273281
keywords: [
274282
'aif',
275283
'mid',
@@ -281,6 +289,7 @@
281289
},
282290
{
283291
name: 'mime-code',
292+
minver: '0.7.0',
284293
keywords: [
285294
'bat',
286295
'css',
@@ -295,6 +304,7 @@
295304
},
296305
{
297306
name: 'mime-data',
307+
minver: '0.7.0',
298308
keywords: [
299309
'csv',
300310
'dat',
@@ -312,6 +322,7 @@
312322
},
313323
{
314324
name: 'mime-image',
325+
minver: '0.7.0',
315326
keywords: [
316327
'ai',
317328
'bmp',
@@ -329,6 +340,7 @@
329340
},
330341
{
331342
name: 'mime-system',
343+
minver: '0.7.0',
332344
keywords: [
333345
'bak',
334346
'bin',
@@ -349,6 +361,7 @@
349361
},
350362
{
351363
name: 'mime-text',
364+
minver: '0.7.0',
352365
keywords: [
353366
'doc',
354367
'docx',
@@ -360,6 +373,7 @@
360373
},
361374
{
362375
name: 'mime-video',
376+
minver: '0.7.0',
363377
keywords: [
364378
'3gp',
365379
'avi',
@@ -397,6 +411,7 @@
397411
},
398412
{
399413
name: 'paperclip',
414+
minver: '0.7.0',
400415
keywords: [
401416
'attachment',
402417
],
@@ -452,13 +467,15 @@
452467
},
453468
{
454469
name: 'server-config',
470+
minver: '0.7.0',
455471
keywords: [
456472
'change',
457473
'manage',
458474
],
459475
},
460476
{
461477
name: 'server-incident',
478+
minver: '0.7.0',
462479
},
463480
{
464481
name: 'sort',
@@ -488,14 +505,14 @@
488505
{
489506
name: 'technical-change',
490507
minver: '0.2.0',
491-
alias: 'server-config',
492508
deprecated: true,
509+
replacement: 'server-config',
493510
},
494511
{
495512
name: 'technical-incident',
496513
minver: '0.2.0',
497-
alias: 'server-incident',
498514
deprecated: true,
515+
replacement: 'server-incident',
499516
},
500517
{
501518
name: 'ticketing',
@@ -527,6 +544,12 @@
527544
'remove',
528545
],
529546
},
547+
{
548+
name: 'upload',
549+
keywords: [
550+
'export',
551+
],
552+
},
530553
{
531554
name: 'user',
532555
minver: '0.1.10',

docs/components/icons/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ <h3 class="hxHeading-4">{{icon.name}}</h3>
7878

7979
<!-- version/deprecation -->
8080
<hx-error v-if="icon.deprecated" class="hxSubBody">
81-
Deprecated
81+
Deprecated (use "{{icon.replacement}}")
8282
</hx-error>
8383
<span v-else>
8484
<small v-if="icon.minver" class="hxSubdued">Added: v{{icon.minver}}</small>

src/helix-ui/icons.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import _envelope from './icons/envelope.svg';
1919
import _exclamationCircle from './icons/exclamation-circle.svg';
2020
import _exclamationDiamond from './icons/exclamation-diamond.svg';
2121
import _exclamationTriangle from './icons/exclamation-triangle.svg';
22-
import _export from './icons/export.svg';
2322
import _externalLink from './icons/external-link.svg';
2423
import _file from './icons/file.svg';
2524
import _filter from './icons/filter.svg';
@@ -74,6 +73,7 @@ import _ticketing from './icons/ticketing.svg';
7473
import _times from './icons/times.svg';
7574
import _timesCircle from './icons/times-circle.svg';
7675
import _trash from './icons/trash.svg';
76+
import _upload from './icons/upload.svg';
7777
import _user from './icons/user.svg';
7878

7979
const MAP = {
@@ -98,7 +98,6 @@ const MAP = {
9898
'exclamation-circle': _exclamationCircle,
9999
'exclamation-diamond': _exclamationDiamond,
100100
'exclamation-triangle': _exclamationTriangle,
101-
'export': _export,
102101
'external-link': _externalLink,
103102
'file': _file,
104103
'filter': _filter,
@@ -153,10 +152,12 @@ const MAP = {
153152
'times': _times,
154153
'times-circle': _timesCircle,
155154
'trash': _trash,
155+
'upload': _upload,
156156
'user': _user,
157157
};
158158

159159
// DEPRECATED: remove in v1.0.0
160+
MAP['export'] = MAP['upload'];
160161
MAP['input-url'] = MAP['globe'];
161162
MAP['technical-change'] = MAP['server-config'];
162163
MAP['technical-incident'] = MAP['server-incident'];
File renamed without changes.

0 commit comments

Comments
 (0)