fix(CSS): remove margins on positioned elements

Ryan A. Johnson · Ryan A. Johnson · commit c58274e2850b · 2018-10-10T15:18:00.000-05:00
diff --git a/src/helix-ui/styles/elements/hx-menu.less b/src/helix-ui/styles/elements/hx-menu.less
@@ -14,18 +14,19 @@ hx-menu {
     &:extend(.hxBox-sm);
 
     display: block;
+    margin: 0;
   }
 
   > section {
     display: block;
-  
+
     header {
       color: @gray-600;
       font-size: 0.875rem;
       font-weight: 500;
       text-transform: uppercase;
     }
-  
+
     + section {
       margin-top: 0.5rem;
     }
diff --git a/src/helix-ui/styles/elements/hx-popover.less b/src/helix-ui/styles/elements/hx-popover.less
@@ -27,6 +27,7 @@ hx-popover {
   &[open] {
     display: flex;
     flex-direction: column;
+    margin: 0;
   }
 
   & > &-head {
diff --git a/src/helix-ui/styles/elements/hx-search-assistance.less b/src/helix-ui/styles/elements/hx-search-assistance.less
@@ -3,5 +3,6 @@ hx-search-assistance {
 
   &[open] {
     display: block;
+    margin: 0;
   }
 }
diff --git a/src/helix-ui/styles/elements/hx-tooltip.less b/src/helix-ui/styles/elements/hx-tooltip.less
@@ -27,5 +27,6 @@ hx-tooltip {
 
     &[open] {
         display: block;
+        margin: 0;
     }
 }
diff --git a/src/helix-ui/styles/overrides.less b/src/helix-ui/styles/overrides.less
@@ -12,6 +12,8 @@
 p {
   margin: 0;
 
+  // FIXME: this has the potential to throw off alignment
+  // of fixed position elements like tooltips and popovers
   & + * {
     margin-top: 0.5rem;
   }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@`
`12`	`12`	`p {`
`13`	`13`	`margin: 0;`
`14`	`14`
	`15`	`+ // FIXME: this has the potential to throw off alignment`
	`16`	`+ // of fixed position elements like tooltips and popovers`
`15`	`17`	`& + * {`
`16`	`18`	`margin-top: 0.5rem;`
`17`	`19`	`}`