Merge pull request #86 from rackerlabs/misc-test-fixes

Misc test fixes

Author: Droogans

README.md

@@ -3,6 +3,7 @@
 ## Developer Setup
 
 0. [install yarn](https://yarnpkg.com/en/docs/install)
+0. [install test dependencies](https://github.com/rackerlabs/helix-ui/wiki/Testing#system-requirements)
 0. `yarn install` to install project dependencies
 0. `yarn start` to begin working
 

bin/start.js

@@ -41,7 +41,7 @@ browserSync.init({
                  * synchronous build events to complete so that browserSync can finish
                  * and reload the page (and therefore, allow selenium to connnect).
                  */
-                const tests = exec('yarn run test:regression -- -u', { cwd: CONFIG.testDir });
+                const tests = exec('yarn run test:regression -u', { cwd: CONFIG.testDir });
                 // this *is* asynchronous, see comment above
                 tests.stdout.pipe(process.stdout);
                 tests.stderr.pipe(process.stderr);
@@ -52,7 +52,8 @@ browserSync.init({
         {
             match: [
                 `${CONFIG.testDir}/**/*.ts`,
-                `!${CONFIG.testDir}/built/**/*`
+                `!${CONFIG.testDir}/node_modules/**`,
+                `!${CONFIG.testDir}/built/**/*`,
             ],
             fn: () => {
                 const tsc = exec('yarn run build', { cwd: CONFIG.testDir });

test/.gitignore

@@ -1,8 +1,5 @@
 .github-token
 bin/visreg.config.ts
 built/*
-!built/{functional,regression}/
-built/{functional,regression}/*
-!built/{functional,regression}/*.js.snap
-!built/{functional,regression}/*.js.md
-screenshots
+artifacts/visregScreenshots
+artifacts/regressionScreenshots

test/artifacts/README.md

@@ -0,0 +1,8 @@
+# Test Artificats
+
+This is where helix-ui's test suites generate two types of output:
+
+0. [DOM Snapshots](https://github.com/rackerlabs/helix-ui/wiki/Testing#dom-snapshots).
+0. [Visual regression screenshot catalogs](https://github.com/rackerlabs/helix-ui/wiki/Testing#introduction).
+
+For more information about these types of artifacts, and how they're used, follow the links above.

test/built/functional/hx-reveal.js.md renamed to test/artifacts/domSnapshots/built/functional/hx-reveal.js.md

@@ -17,10 +17,9 @@
   },
   "scripts": {
     "build": "tsc",
-    "clean": "npm run clean:visreg && npm run clean:func",
-    "clean:func": "scripts/deleteEverythingButSnapshots.sh functional",
-    "clean:regression": "scripts/deleteEverythingButSnapshots.sh regression",
-    "clean:visreg": "rm -rf visreg/screenshots built/visreg",
+    "clean": "npm run clean:visreg && npm run clean:regression && rm -rf built",
+    "clean:visreg": "rm -rf artifacts/visregScreenshots",
+    "clean:regression": "rm -rf artifacts/regressionScreenshots",
     "lint": "tslint -c tslint.json visreg/ functional/",
     "pretest": "npm run build",
     "test": "npm run test:func && npm run test:regression && npm run test:visreg",
@@ -35,7 +34,7 @@
     "webdriver:update": "scripts/webdriver-update"
   },
   "ava": {
-    "snapshotLocation": "test/snapshots",
+    "snapshotDir": "artifacts/domSnapshots",
     "failWithoutAssertions": false
   }
 }

test/built/functional/hx-reveal.js.snap renamed to test/artifacts/domSnapshots/built/functional/hx-reveal.js.snap

@@ -23,7 +23,7 @@ while (matched = componentExtractor.exec(taggedForRegression)) {
 test.before(async () => {
     const config: IConfig = {
         browser: "firefox",
-        screenshotsDir: "regression/screenshots",
+        screenshotsDir: "artifacts/regressionScreenshots",
         logException: [
             "MISMATCH",
             "NO_BASELINE",