Merge pull request #135 from rackerlabs/surf-811-menu-aria-attrs

fix(menus): correct ARIA attributes

Author: CITguy

src/helix-ui/elements.js

@@ -2,6 +2,7 @@ export { HXCheckboxElement } from './elements/HXCheckboxElement.js';
 export { HXDisclosureElement } from './elements/HXDisclosureElement.js';
 export { HXIconElement } from './elements/HXIconElement.js';
 export { HXMenuElement } from './elements/HXMenuElement.js';
+export { HXMenuitemElement } from './elements/HXMenuitemElement.js';
 export { HXModalElement } from './elements/HXModalElement.js';
 export { HXPopoverElement } from './elements/HXPopoverElement.js';
 export { HXRevealElement } from './elements/HXRevealElement.js';

src/helix-ui/elements/HXMenuElement.js

@@ -20,6 +20,7 @@ export class HXMenuElement extends HXElement {
         this.$upgradeProperty('position');
         this.$upgradeProperty('relativeTo');
         this.$defaultAttribute('position', 'bottom-start');
+        this.$defaultAttribute('role', 'menu');
         this._initialPosition = this.position;
         document.addEventListener('click', this._onDocumentClick);
     }
@@ -29,7 +30,7 @@ export class HXMenuElement extends HXElement {
     }
 
     attributeChangedCallback (attr, oldValue, newValue) {
-        this.setAttribute('aria-expanded', newValue !== '');
+        this.setAttribute('aria-expanded', newValue === '');
     }
 
     set position (value) {

src/helix-ui/elements/HXMenuitemElement.js

@@ -0,0 +1,11 @@
+import { HXElement } from './HXElement';
+
+export class HXMenuitemElement extends HXElement {
+    static get is () {
+        return 'hx-menuitem';
+    }
+
+    connectedCallback () {
+        this.$defaultAttribute('role', 'menuitem');
+    }
+}//HXMenuitemElement