Merge pull request #418 from rackerlabs/surf-1516-refactor-div

refactor(hx-div): compatability audit updates

Author: 100stacks

src/helix-ui/elements/HXDivElement.js

@@ -29,22 +29,21 @@ export class HXDivElement extends HXElement {
         return `<style>${shadowStyles}</style>${shadowMarkup}`;
     }
 
+    $onDisconnect () {
+        this._removeScrollListeners();
+    }
+
     static get $observedAttributes () {
         return [ 'scroll' ];
     }
 
-    // FIXME: ensure 'scroll' event listener added on connect (if scroll attr present)
-    // FIXME: ensure 'scroll' event listener is removed on disconnect
-
     $onAttributeChange (attr, oldVal, newVal) {
         if (attr === 'scroll') {
-            // FIXME: only run if connected
             if (newVal !== null) {
                 this._resetScroll();
                 this.addEventListener('scroll', onScroll);
             } else {
-                // FIXME: listener doesn't get removed if element disconnects
-                this.removeEventListener('scroll', onScroll);
+                this._removeScrollListeners();
             }
         }
     }
@@ -69,4 +68,9 @@ export class HXDivElement extends HXElement {
         this.scrollTop = 0;
         this.scrollLeft = 0;
     }
+
+    /** @private */
+    _removeScrollListeners () {
+        this.removeEventListener('scroll', onScroll);
+    }
 }